1386112 - For locales with a localized Firefox home, redirect /products to /firefox

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, enhancement)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

I just noticed we still have /firefox/products/ pages in some locales that seem to have a localized Firefox hub. For example:

https://www.mozilla.org/de/firefox/
https://www.mozilla.org/de/firefox/products/

1) Is there a way we can identify all the locales where this is true?
2) Can we permanently redirect all those firefox/products/ pages to the firefox home at /firefox/ ?

Comment 1

[Peiying Mo [:CocoMo]]

Here are some stats: file name/activated (completed) locales
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/ios.lang: 32 (35)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/focus.lang 32 (33)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/desktop.lang 31 (34)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/android.lang 34 (37)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/developer.lang 23 (24)

* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/shared.lang 41

There reason that there is a different between activated locales and completed locales is that they are connected with firefox/shared.lang file. The shared file must be completed before any of the other files can be activated upon completion or we will have pages mixing target language with English.

Comment 2

[Craig Cook (:craigcook)]

So the current line of thinking is that instead of a convoluted selective redirect we may have enough l10n coverage on the Firefox pages to just decommission /products entirely and redirect all locales. That was always the plan, we just need to decide how much coverage is enough.

Comment 3

[Eric Renaud [:erenaud]]

(In reply to Peiying Mo [:CocoMo] from comment #1)
> Here are some stats: file name/activated (completed) locales
> *
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/products/ios.lang: 32 (35)
> *
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/products/focus.lang 32 (33)
> *
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/products/desktop.lang 31 (34)
> *
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/products/android.lang 34 (37)
> *
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/products/developer.lang 23 (24)
> 
> *
> https://l10n.mozilla-community.org/langchecker/
> ?locale=all&website=0&file=firefox/shared.lang 41
> 
> There reason that there is a different between activated locales and
> completed locales is that they are connected with firefox/shared.lang file.
> The shared file must be completed before any of the other files can be
> activated upon completion or we will have pages mixing target language with
> English.

These numbers are climbing - 

* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/ios.lang: 40 (41)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/focus.lang 40 (40)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/desktop.lang 42 (43)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/android.lang 43 (44)
* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/products/developer.lang 36 (36)

* https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/shared.lang 48

Peiying - at what number do you feel we can call 'enough coverage' to decom /products entirely and redirect all locales? There is consistency as I look through the locales who haven't started each of the above .lang files, so I'm wondering if the pattern repeats itself enough to where comparisons to other .lang files that have been around longer without string updates will give us that magic number to equate to 'enough'.

Comment 4

[Peiying Mo [:CocoMo]]

We set yesterday (8/15) as the deadline to complete all the new Firefox pages and we have been pushing to get people to complete them in time. 

Most of the key locales have completed the pages so from that perspective, I think we are good. I am not sure if I am the one to make the call.  I was hoping bn-BD and bn-IN (Bangladeshian) have completed but they are not there yet.

Comment 5

[Peiying Mo [:CocoMo]]

Checked with Flod, who says 80% completion is considered good, so we are not quite there yet.

Comment 6

[Francesco Lodolo [:flod]]

Sorry, you just found a bug! 

When the previous server died, the file containing ADI data wasn't copied on the new (temporary) machine (it's not part of the GitHub repository for obvious reasons).

We're definitely good to redirect locale. All pages are well over 95%

Comment 7

[Eric Renaud [:erenaud]]

Jon - can you please pick up this one? Per Fx prioritization this is our top task, reflected accordingly in our kanban board.

Comment 8

[Jonathan Petto [:jpetto]]

:flod suggested we use this opportunity to clean up a bunch of old pages that will no longer be accessible after the change described above. These pages to remove are:

/firefox/android/index.html
/firefox/android/faq.html (will redirect to https://support.mozilla.org/products/mobile)
/firefox/developer.html
/firefox/features.html
/firefox/ios.html

FWIW, it may be time to remove the old /firefox/desktop pages as well, but saving that for another time/bug.

Comment 9

[Eric Renaud [:erenaud]]

Alex, please pick up this bug, per my email to follow.

Comment 10

[Alex Gibson [:agibson]]

(In reply to Eric Renaud from comment #9)
> Alex, please pick up this bug, per my email to follow.

It looks like Jon already has a PR for this work, I'll look to review.

https://github.com/mozilla/bedrock/pull/5057

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/15acbe8cb0e25da3719e89587af70d6f4fd21069
[fix bug 1386112] Open Fx Hub to all locales.

Decommission old templates/assets for following URLs:
- /firefox/android/
- /firefox/android/faq/
- /firefox/developer/
- /firefox/family/
- /firefox/features/
- /firefox/ios/

https://github.com/mozilla/bedrock/commit/b74a3569897b0b5bbb449dee38faafcba26e34b0
Merge pull request #5057 from jpetto/bug-1386112-open-fxhub-to-all-locales

[fix bug 1386112] Open Fx Hub to all locales.