1386149 - Add support for toolchain aliases

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1386149 - Allow build jobs to use toolchain aliases instead of toolchain job names.

It is desirable for e.g. smooth toolchain transitions, to be able to
refer them with generic name from toolchain jobs, while they have more
specific names, including version numbers. For example, in a near
future, there could be a linux64-gcc-4.9 toolchain and a linux64-gcc-6.
The default would be former, but at some point we'd want to switch to
the latter, without having to change all the toolchain definitions.

Moreover, when the switch happens, it would be desirable to have some
jobs stick with the old version, which is hard to keep track of when
all the toolchain definitions for build jobs use the same versioned
toolchain. With an alias, jobs that want the default use the alias, and
jobs that want to use a specific version use the versioned toolchain
name.

Review commit: https://reviewboard.mozilla.org/r/163244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163244/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1386149 - Add `mach artifact toolchain` support for toolchain aliases.

Review commit: https://reviewboard.mozilla.org/r/163246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163246/

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8892301 [details]
Bug 1386149 - Allow build jobs to use toolchain aliases instead of toolchain job names.

https://reviewboard.mozilla.org/r/163244/#review168988

::: taskcluster/taskgraph/transforms/toolchain.py:21
(Diff revision 1)
>      of corresponding artifacts to jobs using toolchains.
>      """
>      artifacts = {}
> +    aliases_by_job = {}
> +
> +    def get_info(dict, key, attributes, attribute_name):

This confused me for a bit - can you add a docstring?

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8892302 [details]
Bug 1386149 - Add `mach artifact toolchain` support for toolchain aliases.

https://reviewboard.mozilla.org/r/163246/#review169060

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8892301 [details]
Bug 1386149 - Allow build jobs to use toolchain aliases instead of toolchain job names.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163244/diff/1-2/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8892302 [details]
Bug 1386149 - Add `mach artifact toolchain` support for toolchain aliases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163246/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a651ddc6b0c1
Allow build jobs to use toolchain aliases instead of toolchain job names. r=dustin
https://hg.mozilla.org/integration/autoland/rev/4bedbaac7933
Add `mach artifact toolchain` support for toolchain aliases. r=gps

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a651ddc6b0c1
https://hg.mozilla.org/mozilla-central/rev/4bedbaac7933