Closed
Bug 1386164
Opened 7 years ago
Closed 7 years ago
--with-system-libevent causes build error on webrtc
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(2 files)
59 bytes,
text/x-review-board-request
|
jesup
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
59 bytes,
text/x-review-board-request
|
jesup
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
Whe using --with-system-libevent, ./mach configure throws the following error. 0:06.39 ============================== 0:06.39 ERROR PROCESSING MOZBUILD FILE 0:06.39 ============================== 0:06.39 0:06.39 The error occurred while processing the following file or one of the files it includes: 0:06.39 0:06.39 /mozilla/mozilla-central/media/webrtc/trunk/gtest/moz.build 0:06.39 0:06.39 The error occurred when validating the result of the execution. The reported error is: 0:06.39 0:06.39 USE_LIBS contains "libevent", which does not match any LIBRARY_NAME in the tree. 0:06.39 0:06.39 Maybe, this is from landing bug 1341285.
Updated•7 years ago
|
Rank: 25
Priority: -- → P2
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8893210 -
Flags: review?(rjesup)
Attachment #8893211 -
Flags: review?(rjesup)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8893211 [details] Bug 1386164 - Part 2. Use MOZ_SYSTEM_LIBEVENT for webrtc. https://reviewboard.mozilla.org/r/164248/#review170054
Attachment #8893211 -
Flags: review?(rjesup) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8893210 [details] Bug 1386164 - Part 1. Use libevent2 headers instead of deprecated event.h. https://reviewboard.mozilla.org/r/164246/#review170056
Attachment #8893210 -
Flags: review?(rjesup) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/8ed89673594e Part 1. Use libevent2 headers instead of deprecated event.h. r=jesup https://hg.mozilla.org/integration/autoland/rev/e1ab8bf0905d Part 2. Use MOZ_SYSTEM_LIBEVENT for webrtc. r=jesup
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ed89673594e https://hg.mozilla.org/mozilla-central/rev/e1ab8bf0905d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 8893210 [details] Bug 1386164 - Part 1. Use libevent2 headers instead of deprecated event.h. Approval Request Comment [Feature/Bug causing the regression]: bug 1341285 [User impact if declined]: User cannot build Firefox with --with-system-libevent. This option seems to be used on debian (https://bugzilla.mozilla.org/show_bug.cgi?id=1372546#c14) [Is this code covered by automated tests?]: No, but this is build only issue with specific build flags that we don't use. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No, this is build issue. [List of other uplifts needed for the feature/fix]: No. [Is the change risky?]: No [Why is the change risky/not risky?]: This is build issue. [String changes made/needed]: No
Flags: needinfo?(m_kato)
Attachment #8893210 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•7 years ago
|
Attachment #8893211 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox56:
--- → affected
Comment 10•7 years ago
|
||
Comment on attachment 8893210 [details] Bug 1386164 - Part 1. Use libevent2 headers instead of deprecated event.h. Let's get builds working, please uplift to beta.
Attachment #8893210 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
Attachment #8893211 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
Assignee: nobody → m_kato
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/7b672c34268c https://hg.mozilla.org/releases/mozilla-beta/rev/a3904db13d09
You need to log in
before you can comment on or make changes to this bug.
Description
•