1386182 - Should set FeatureState after EnableByDefault() in gfxWindowsPlatform::InitializeD3D11Config

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kevin Chen[:kechen] (UTC + 8)]

We should set FeatureState after EnableByDefault()[1], it's a regression of 1364563, this part of code works fine in nightly since it only modifies FeatureStae in release and beta.

[1] https://dxr.mozilla.org/mozilla-central/rev/36f95aeb4c77f7cf3b3366583008cd6e4b6b1dba/gfx/thebes/gfxWindowsPlatform.cpp#1356

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Bug 1386182 - Set FeatureState after EnableByDefault() in gfxWindowsPlatform::InitializeD3D11Config;

Review commit: https://reviewboard.mozilla.org/r/163322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163322/

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8892368 [details]
Bug 1386182 - Set FeatureState after EnableByDefault() in gfxWindowsPlatform::InitializeD3D11Config;

https://reviewboard.mozilla.org/r/163322/#review168674

Comment 4

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8892368 [details]
Bug 1386182 - Set FeatureState after EnableByDefault() in gfxWindowsPlatform::InitializeD3D11Config;

This is the uplift for Firefox 56.

Approval Request Comment
[Feature/Bug causing the regression]:
1351349
[User impact if declined]:
User with specific platform and specific graphics card might crash.
[Is this code covered by automated tests?]:
No.
[Has the fix been verified in Nightly?]:
No.
[Needs manual test from QE? If yes, steps to reproduce]:
No. 
[List of other uplifts needed for the feature/fix]:
No.
[Is the change risky?]:
No.
[Why is the change risky/not risky?]:
It is just an one-line change and only change the order of the function call.
[String changes made/needed]:
None.

Comment 5

[Kevin Chen[:kechen] (UTC + 8)]

Some fix for comment 0, the regression bug should be bug 1351349.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a68a71b3310
Set FeatureState after EnableByDefault() in gfxWindowsPlatform::InitializeD3D11Config; r=jerry

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a68a71b3310

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892368 [details]
Bug 1386182 - Set FeatureState after EnableByDefault() in gfxWindowsPlatform::InitializeD3D11Config;

Crash fix, regression from 56, so let's try this for beta 1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b9a1d5b16ee

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Kevin Chen[:kechen] (UTC + 8) from comment #4)
> [Is this code covered by automated tests?]:
> No.
> [Has the fix been verified in Nightly?]:
> No.
> [Needs manual test from QE? If yes, steps to reproduce]:
> No. 

Setting qe-verify- based on Kevin Chen's assessment on manual testing needs.