1386218 - Remove gfxContext::HasComplexClip.

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P5)

Description

[u459114]

This function is not used in current codebase, and should be removed.

Comment 1

[♥ Ami ♥]

Hi, I'd like to take this as my first bug. I removed the function and successfully built the code on my laptop, what's next step should I do? Thank you.

Comment 2

[u459114]

Hi,
Please refer to the introduction here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Since you had built correctly, I think you may move forward to "Step 4 - Get your code reviewed"

Comment 3

[♥ Ami ♥]

Attachment: Remove a unused function

Hi, I've removed the function never being used, would you review it? Thank you so much.

Comment 4

[Astley Chen (inactive)]

Thank you for working on this bug! Enjoy your first patch~

Comment 5

[u459114]

r+ granted, next step is make sure all test cases pass by your change("Step 6 - Actually get the code into the tree")

After that, add the checkin-needed keyword to the bug (or if Bugzilla doesn't allow you to add the keyword, ask someone else to add it).

Comment 6

[♥ Ami ♥]

Thanks for all of your help :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/092017bb63c9
remove unused function gfxContext::HasComplexClip; r=jrmuizel

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/092017bb63c9

Comment 9

[Astley Chen (inactive)]

(In reply to ♥ Ami ♥ from comment #6)
> Thanks for all of your help :)

Thanks for working on this bug. Let us know if you'd like to take more. :)