Remove gfxContext::HasComplexClip.

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: u459114, Assigned: ami.bugzilla)

Tracking

({good-first-bug})

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
This function is not used in current codebase, and should be removed.
Priority: -- → P5
Assignee

Comment 1

2 years ago
Hi, I'd like to take this as my first bug. I removed the function and successfully built the code on my laptop, what's next step should I do? Thank you.
Reporter

Comment 2

2 years ago
Hi,
Please refer to the introduction here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Since you had built correctly, I think you may move forward to "Step 4 - Get your code reviewed"
Assignee

Comment 3

2 years ago
Hi, I've removed the function never being used, would you review it? Thank you so much.
Attachment #8892802 - Flags: review?(jmuizelaar)
Reporter

Updated

2 years ago
Assignee: nobody → ami.bugzilla
Thank you for working on this bug! Enjoy your first patch~
Status: NEW → ASSIGNED
Attachment #8892802 - Flags: review?(jmuizelaar) → review+
Reporter

Comment 5

2 years ago
r+ granted, next step is make sure all test cases pass by your change("Step 6 - Actually get the code into the tree")

After that, add the checkin-needed keyword to the bug (or if Bugzilla doesn't allow you to add the keyword, ask someone else to add it).
Assignee

Comment 6

2 years ago
Thanks for all of your help :)
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 7

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/092017bb63c9
remove unused function gfxContext::HasComplexClip; r=jrmuizel
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/092017bb63c9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to ♥ Ami ♥ from comment #6)
> Thanks for all of your help :)

Thanks for working on this bug. Let us know if you'd like to take more. :)
You need to log in before you can comment on or make changes to this bug.