1386275 - CSS Grid Inspector: change color palette

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Jen Simmons [:jensimmons]]

Now that I've had a chance to use the default color palette on a lot of projects, I've realized that in 80% of usecases, the default colors need to be changed. I think if we shift the color palette, we can provide colors that work more often. 

Here's the current set of colors: https://monosnap.com/file/1eJ2agnNjEsknD046MolITVwq8nbTO.png
(which I believe came from a palette I made last year: https://codepen.io/jensimmons/pen/RadKvR)

This is what I think will work better: https://monosnap.com/file/Z0rKbc3z2hUgD7QhNw5T6D4hVeI7W9.png

Here are the hexadecimal numbers:
#840CDB
#FF00F1
#007EED
#12B400
#E22100
#869407
#09BEB2
#B71A6C
#1D9617
#6763F4
#BA790F
#E10FB1

What do you think? Shall we change the numbers?

Comment 1

[Victoria Wang [:victoria]]

Attachment: grid colors

Comment 2

[Victoria Wang [:victoria]]

I attached a screenshot of suggested colors. They're based on Jen's but adjusted to match the design system, with a couple switches in ordering.

#9400ff Purple 50
#DF00A9 Magenta 60
#0a84ff Blue 50
#12bc00 Green 60
#EA8000
#00B0BD
#d70022 Red 60
#4B42FF
#b5007f Magenta 70
#058b00 Green 70
#A47F00 Yellow 70
#005a71 Teal 80

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1386275.patch

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8892735 [details] [diff] [review]
1386275.patch

Review of attachment 8892735 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cdd08ad685c
Update the grid overlay color palette. r=jdescottes

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=120436678&repo=mozilla-inbound

So far I'm only seeing this failure on Win7 PGO builds, but that might not mean anything.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b400e035f30cc5156fcfcd10b768d27aae5b4a6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7aec500a6061
Update the grid overlay color palette. r=jdescottes

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7aec500a6061

Comment 9

[Md. Majedul islam]

I have reproduced this bug with Nightly 56.0a1 (2017-08-01) on ubuntu 16.04 (64 Bit)

This bug's fix is verified on Latest Nightly 57.0a1.

Build ID : 20170805100334

User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 10

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 56.0a1 (2017-08-01) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-08-10) (32-bit)

Build ID: 20170810100255
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0