Closed
Bug 1386384
Opened 7 years ago
Closed 7 years ago
Stylo: Regenerate DevTools CSS test fixtures when Stylo is default
Categories
(Core :: CSS Parsing and Computation, defect, P5)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
Details
Attachments
(1 file)
DevTools saves test fixture that records exact CSS error messages. Stylo produces slightly different data for these, so they aren't an exact match. I think the simplest path is to store a separate copy of the data for use with Stylo.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
Ah, it turns out the real tests that use this fixture data don't currently run on Mozilla CI anyway, so the only thing being tested is that the fixture data is unchanged. For now, I'll skip the fixture check test (devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser_webconsole_check_stubs_css_message.js). Once Stylo is the default, we can regenerate the fixtures and enable the test again.
Priority: -- → P5
Summary: Stylo: Separate DevTools CSS test fixtures → Stylo: Regenerate DevTools CSS test fixtures when Stylo is default
Assignee | ||
Updated•7 years ago
|
Assignee: jryans → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=44e491410f1024089c522ed4633a9275a2d25d8c
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8905167 [details] Bug 1386384 - Update DevTools CSS stubs for Stylo. https://reviewboard.mozilla.org/r/176954/#review181960 Stylo is riding the train to release, right? So we don't need to special case this test for beta/release?
Attachment #8905167 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8905167 [details] Bug 1386384 - Update DevTools CSS stubs for Stylo. https://reviewboard.mozilla.org/r/176954/#review181960 Correct!
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3adbca67c67a Update DevTools CSS stubs for Stylo. r=bgrins
Backed out for dt failures like https://treeherder.mozilla.org/logviewer.html#?job_id=129022789&repo=autoland Seems exclusive to the stylo-disabled variants. https://hg.mozilla.org/integration/autoland/rev/60a28a7012ed
Flags: needinfo?(jryans)
Comment 8•7 years ago
|
||
I guess we should skip the test in non stylo builds now
Assignee | ||
Comment 9•7 years ago
|
||
Ah, I guess I should have seen that coming... :S
Flags: needinfo?(jryans)
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/08f5c5e4f3b1 Update DevTools CSS stubs for Stylo. r=bgrins
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/08f5c5e4f3b1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•