1386406 - Audit animation CSS to make sure that each animation-duration is set to 60fps based on step count

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

From bug 1383689, I noticed that we weren't using the correct 60fps timing for the animation-duration, and in that patch I arrived at the animation-duration by multiplying the steps (69) by 16 (16ms for each frame). However, this approximation is wrong and on a large number of frames it may get off by a lot (in this example 46ms).

We should make sure that the animation-duration is set to step-count / 60, which will give us the correct animation-duration based on the number of frames.

With the incorrect animation-duration, it is possible that we will skip frames during the animation as vsync keeps us at 60fps.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1386406 - Update animation-duration of the Photon animations to match 60fps timing.

Review commit: https://reviewboard.mozilla.org/r/163624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163624/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The values used in this patch are based on step-count / 60. If necessary, rounding up to the closest millisecond.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8892635 [details]
Bug 1386406 - Update animation-duration of the Photon animations to match 60fps timing.

https://reviewboard.mozilla.org/r/163624/#review169082

Checks out. I've made a note to update the download start animation in the same way.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c56fec3372fe
Update animation-duration of the Photon animations to match 60fps timing. r=sfoster

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c56fec3372fe