1386414 - rustc 1.21.0-nightly fails to build stylo with rustdoc warnings

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Ralph Giles (:rillian)]

rustc 1.21.0-nightly (37c7d0ebb 2017-07-31) fails to compile today's stylo.

> 2:02.51    Compiling style v0.0.1 (file:///home/giles/firefox/servo/components/style)
> 3:02.19 error: doc comment not used by rustdoc
> 3:02.19    --> /home/giles/firefox/servo/components/style/values/specified/image.rs:689:17
> 3:02.19     |
> 3:02.19 689 |                 /// `to` keyword is mandatory in modern syntax.
> 3:02.19     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 3:02.19     |
> 3:02.19 note: lint level defined here
> 3:02.19    --> /home/giles/firefox/servo/components/style/lib.rs:26:9
> 3:02.19     |
> 3:02.19 26  | #![deny(warnings)]
> 3:02.19     |         ^^^^^^^^
> 3:02.19     = note: #[deny(unused_doc_comment)] implied by #[deny(warnings)]
> [...]
> 3:02.19 error: internal compiler error: /checkout/src/librustc_typeck/astconv.rs:1267: anonymous bound region BrAnon(1) in return but not args
> 3:02.19    --> /home/giles/firefox/obj-x86_64-pc-linux-gnu/toolkit/library/x86_64-unknown-linux-gnu/debug/build/style-b88ec12e074624e1/out/gecko/bindings.rs:523:9
> 3:02.19     |
> 3:02.19 523 |      -> RawGeckoNodeBorrowedOrNull;
> 3:02.19     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
> 3:02.19 
> 3:02.19 note: the compiler unexpectedly panicked. this is a bug.

The compiler is warning about the `to` annotation not being interpretable as code.

The ICE is already filed as https://github.com/rust-lang/rust/issues/43567

Comment 1

[Chris Peterson [:cpeterson]]

Manish changed the doc comment to a regular comment to fix the rustdoc warning:

https://github.com/servo/servo/pull/17934

Comment 2

[Chris Peterson [:cpeterson]]

The rustc ICE was fixed today, so building Stylo with with rustc nightly will probably work tomorrow.

https://github.com/rust-lang/rust/issues/43567#issuecomment-322721280

Comment 3

[Ralph Giles (:rillian)]

Attachment: Bug 1386414 - Update builders to rust 1.21.0-nightly (7ac979d8c 2017-08-16)

Repack of upstream builds for testing.

Review commit: https://reviewboard.mozilla.org/r/169964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169964/

Comment 4

[Ralph Giles (:rillian)]

Confirming I can build with rust 1.21.0-beta.2.