Closed Bug 1386439 Opened 2 years ago Closed 2 years ago

Record image-drawing in RasterImage::GetImageContainer and RasterImage::GetFrameAtSize for browser_image_startup.js

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Status
firefox57 --- fixed

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Whiteboard: [reserve-photon-performance])

Attachments

(1 file)

Quoting tnikkel from bug 1363059 comment 44:

> There are other ways that a RasterImage gets used beside DrawInternal.
> GetImageContainer and GetFrame/GetFrameAtSize specifically.

From a quick local test this would make at least 3 whitelist items unnecessary.
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [photon-performance] → [reserve-photon-performance]
Whitelist changes are subject to fine-tuning after looking at try results. :)
Comment on attachment 8892795 [details]
Bug 1386439 - Record image-drawing in RasterImage::GetImageContainer and RasterImage::GetFrameAtSize for browser_image_startup.js.

https://reviewboard.mozilla.org/r/163784/#review169400

Thanks!
Attachment #8892795 - Flags: review?(tnikkel) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 15dc93013a96 -d 192f97d9e355: rebasing 411228:15dc93013a96 "Bug 1386439 - Record image-drawing in RasterImage::GetImageContainer and RasterImage::GetFrameAtSize for browser_image_startup.js. r=tnikkel" (tip)
merging browser/base/content/test/performance/browser_startup_images.js
warning: conflicts while merging browser/base/content/test/performance/browser_startup_images.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
The merge conflict is likely with bug 1349555 on autoland, but considering that one is prone to get backed out, I'm holding off on landing this until the other patch is on central.
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3c007933d81
Record image-drawing in RasterImage::GetImageContainer and RasterImage::GetFrameAtSize for browser_image_startup.js. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/c3c007933d81
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Iteration: --- → 57.1 - Aug 15
You need to log in before you can comment on or make changes to this bug.