1386519 - The index path for toolchain jobs should vary depending on the toolchains they use.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

Here's what I was doing and what happened: I was trying to rebuild clang with an older version of gcc. I actually built the older version of gcc with a try push, and then tried the clang build on top of that in a separate try. What happened is that the decision task optimized both the gcc and the clang builds because they both were in the index, so clang was never rebuilt with the older version of gcc.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1386519 - Make the index path for toolchain jobs vary depending on dependencies.

The premise for simply using the dependencies task names is that if the
name of dependencies changes, or their number, that will impact the
index path, forcing a new build. If there is no such change, but one or
several of the dependencies themselves have changes, they will get a new
build, which will force a new build for the job that depends on them.

In that latter case, the index path will be the same as before the
changes, but that is already what's happening today.

Review commit: https://reviewboard.mozilla.org/r/163880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163880/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8892863 [details]
Bug 1386519 - Make the index path for toolchain jobs vary depending on dependencies.

https://reviewboard.mozilla.org/r/163880/#review169246

Neat - I bet we can use this someday to do multi-stage docker builds..

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9222ebba6d4d
Make the index path for toolchain jobs vary depending on dependencies. r=dustin

Comment 4

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/9222ebba6d4d32926d19cc5e9ffacf3d5abe8b2d
Bug 1386519 - Make the index path for toolchain jobs vary depending on dependencies. r=dustin