1386523 - Move store debug logging in test as an option of openNewTabAndConsole helper

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

We have a few tests that use the same snippet to log every store changes (http://searchfox.org/mozilla-central/search?q=store.subscribe(()+%3D%3E+{&case=false&regexp=false&path=devtools%2Fclient%2Fwebconsole).
This could be moved to the opennewTabAndConsole helper function, as an option

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1386523 - Make store debug logging into a shared helper function for webconsole mochitests;

Review commit: https://reviewboard.mozilla.org/r/215046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215046/

Comment 2

[Brian Grinstead [:bgrins]]

Ended up making this a separate helper function instead of an option on openNewTabAndConsole since at least one of the consumers wasn't already using openNewTabAndConsole. To really clean this up I think we'd want to update every test possible to use openNewTabAndConsole, and then change signature there to make options an object (instead of adding a third param after clearJstermHistory). That said, I think this on it's own is a simple improvement and I didn't have the time today to do more.

By the way, the logging had broken on `store.getState().messages.messagesById.reduce` with "reduce is not a function" since messagesById is a Map now, so this patch fixes that as well. It wasn't causin test failures since the error was happening in the subscribe callback.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8944882 [details]
Bug 1386523 - Make store debug logging into a shared helper function for webconsole mochitests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215046/diff/1-2/

Comment 4

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9879c08ca2358f91de44d0872d5beb2b1f8f468e

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8944882 [details]
Bug 1386523 - Make store debug logging into a shared helper function for webconsole mochitests;

https://reviewboard.mozilla.org/r/215046/#review220808

Looks good to me, thanks Brian

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5aa587585663
Make store debug logging into a shared helper function for webconsole mochitests;r=nchevobbe

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5aa587585663