Closed
Bug 1386646
Opened 7 years ago
Closed 7 years ago
Remove most GetJitContext calls
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
94.26 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
We'd like to remove GetJitContext at some point, because it encourages writing code that does a lot of TLS lookups and is slower than necessary.
Here's a patch to remove most of these calls. Removing all of them is a bit more work and not on my radar atm, but after this patch it should be easier to see what's left.
Attachment #8892917 -
Flags: review?(luke)
|
||
Updated•7 years ago
|
Attachment #8892917 -
Flags: review?(luke) → review+
|
Assignee | |
Comment 2•7 years ago
|
||
(In reply to Ted Campbell [:tcampbell] from comment #1)
> I think this closes bug 1360624
Not entirely because there are still a number of them left, but I'll comment there.
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4346a6f167be
Remove most GetJitContext calls. r=luke
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/projects/date/rev/4346a6f167bebf61d5760888043c8cb5cba990f5
Bug 1386646 - Remove most GetJitContext calls. r=luke
You need to log in
before you can comment on or make changes to this bug.
Description
•