1386666 - Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, enhancement)

Description

[Dan Banner]

try...catch(ex if ex) isn't on a standards line and is specific to gecko.

As a result, ESLint doesn't support it, and therefore can't parse files containing it.

As part of the work towards bug 1379256, we should remove the catch(ex if ex) statements.

Comment 1

[Dan Banner]

Attachment: Bug 1386666 - Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files.

Review commit: https://reviewboard.mozilla.org/r/163952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163952/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8892929 [details]
Bug 1386666 - Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files.

https://reviewboard.mozilla.org/r/163952/#review169320

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/856215476aa4
Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files. r=mossop

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This caused a handful of lint failures: https://treeherder.mozilla.org/logviewer.html#?job_id=120465807&repo=autoland

Backed out in https://hg.mozilla.org/integration/autoland/rev/0e4a8e3983e42b0ef9fb2be2d825582f512026c9

Comment 5

[Dan Banner]

Comment on attachment 8892929 [details]
Bug 1386666 - Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163952/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4558c7896403
Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files. r=mossop

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4558c7896403

Comment 8

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/856215476aa45721d2b333e65666b3f2b21f0184
Bug 1386666 - Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files. r=mossop

https://hg.mozilla.org/projects/date/rev/4558c7896403e46dc3f6c945ac6239b8cdbfa93e
Bug 1386666 - Remove try..catch(ex if ex) statements from toolkit/components/osfile/ so that ESLint can parse the files. r=mossop