1386712 - [geckoview] Media continues playing in Custom Tab after closed

Status: RESOLVED FIXED

(GeckoView :: Media, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

If I open a page that plays video in a custom tab, then back out of the custom tab, I still hear the audio playing.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

I see this on a Galaxy S7, but on a Nexus 5X it appears to work fine.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

It works on Nexus 5 Android 6.0.1

Comment 3

[Nicole Yee (:nicoleyee)]

Sorina, Can you please test and see if this is reproducible on different devices.

Comment 4

[Sorina Florean [:sflorean]]

Tested on following devices:
 - Huawei Honor (Android 5.1.1), 
 - Motorola Nexus 6 (Android 7.1.1);
 - Oneplus Two (Android 6.0.1);
 Opened a video, closed from "x" button - toolbar and I can hear the video for 1 sec. If the video is closed from device back button, I'm not hearing the sound.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

I think it's okay if we hear the video for only 1 sec?

Comment 6

[Dylan Roeh (:droeh) (he/him)]

Attachment: Quick workaround

I think this has the potential to be a bit annoying for users, and there's a simple enough workaround for the time being: just load about:blank in CustomTabsActivity.finish() to stop media playback immediately. I'm investigating at the moment if it's a broader issue that will affect GV consumers, in which case we may want to do something a bit nicer.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8909965 [details] [diff] [review]
Quick workaround

Review of attachment 8909965 [details] [diff] [review]:
-----------------------------------------------------------------

I really think we need to find another way to fix this...

Comment 8

[Dylan Roeh (:droeh) (he/him)]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #7)
> Comment on attachment 8909965 [details] [diff] [review]
> Quick workaround
> 
> Review of attachment 8909965 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I really think we need to find another way to fix this...

Yeah, I'm still looking into the crash we see if we implement the destroy/release API we talked about for GeckoView; when I've got that figured out hopefully we can uplift it and get rid of this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c86578718e19
Load about:blank in CustomTabsActivity.finish() to immediately stop media playback. r=snorp

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdffa3d29768
Add null-checking to fix test bustage. r=me

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c86578718e19
https://hg.mozilla.org/mozilla-central/rev/fdffa3d29768

Comment 12

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.