Closed Bug 1386776 Opened 2 years ago Closed 2 years ago

Beta shouldn't schedule nightly l10n on-push

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla56

People

(Reporter: Callek, Assigned: jlorenzo)

References

Details

Attachments

(2 files)

looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=60ee1059ee6c76d9dff806aee85bb29bcd20fba0&filter-searchStr=l10n we see nightly l10n tasks for windows and OSX. This is because repackage for l10n is running on-push for beta.
Was talking to :jlorenzo in the morning and we were wondering if this[1] is the culprit?

[1]: https://hg.mozilla.org/mozilla-central/rev/5533bb014569#l1.15
See Also: → 1386995
Sorry, I'm stealing that bug from you [after I looked at bug 1386995]. 

This patch takes beta from 4035 tasks (after optimization) to 3447. See deleted tasks in here.

The issue was that repackage-signing was scheduling l10n builds/repacks.
Comment on attachment 8893367 [details]
Bug 1386776 - Beta shouldn't schedule nightly l10n on-push

https://reviewboard.mozilla.org/r/164466/#review169748

Nice solution, I wish I'd have thought of that!

::: taskcluster/taskgraph/target_tasks.py:258
(Diff revision 1)
>  @_target_task('mozilla_beta_tasks')
>  def target_tasks_mozilla_beta(full_task_graph, parameters):
>      """Select the set of tasks required for a promotable beta or release build
>      of linux, plus android CI. The candidates build process involves a pipeline
>      of builds and signing, but does not include beetmover or balrog jobs."""
> +    task_kinds = []

is this used?
Attachment #8893367 - Flags: review?(bugspam.Callek) → review+
Assignee: bugspam.Callek → jlorenzo
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88fb9218e618
Beta shouldn't schedule nightly l10n on-push r=Callek
https://hg.mozilla.org/mozilla-central/rev/88fb9218e618
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Thanks for the uplift, Ryan!
Target Milestone: mozilla57 → mozilla56
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.