Beta shouldn't schedule nightly l10n on-push

RESOLVED FIXED in mozilla56

Status

RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: Callek, Assigned: jlorenzo)

Tracking

unspecified
mozilla56

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=60ee1059ee6c76d9dff806aee85bb29bcd20fba0&filter-searchStr=l10n we see nightly l10n tasks for windows and OSX. This is because repackage for l10n is running on-push for beta.
No longer blocks: 1386694
Was talking to :jlorenzo in the morning and we were wondering if this[1] is the culprit?

[1]: https://hg.mozilla.org/mozilla-central/rev/5533bb014569#l1.15
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
Created attachment 8893368 [details] [diff] [review]
Tasks taken out from beta on push

Sorry, I'm stealing that bug from you [after I looked at bug 1386995]. 

This patch takes beta from 4035 tasks (after optimization) to 3447. See deleted tasks in here.

The issue was that repackage-signing was scheduling l10n builds/repacks.
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8893367 [details]
Bug 1386776 - Beta shouldn't schedule nightly l10n on-push

https://reviewboard.mozilla.org/r/164466/#review169748

Nice solution, I wish I'd have thought of that!

::: taskcluster/taskgraph/target_tasks.py:258
(Diff revision 1)
>  @_target_task('mozilla_beta_tasks')
>  def target_tasks_mozilla_beta(full_task_graph, parameters):
>      """Select the set of tasks required for a promotable beta or release build
>      of linux, plus android CI. The candidates build process involves a pipeline
>      of builds and signing, but does not include beetmover or balrog jobs."""
> +    task_kinds = []

is this used?
Attachment #8893367 - Flags: review?(bugspam.Callek) → review+
(Reporter)

Updated

a year ago
Assignee: bugspam.Callek → jlorenzo
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88fb9218e618
Beta shouldn't schedule nightly l10n on-push r=Callek

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/88fb9218e618
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Assignee)

Comment 9

a year ago
Thanks for the uplift, Ryan!
Target Milestone: mozilla57 → mozilla56

Updated

6 months ago
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.