1386776 - Beta shouldn't schedule nightly l10n on-push

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Justin Wood (:Callek)]

looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=60ee1059ee6c76d9dff806aee85bb29bcd20fba0&filter-searchStr=l10n we see nightly l10n tasks for windows and OSX. This is because repackage for l10n is running on-push for beta.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Was talking to :jlorenzo in the morning and we were wondering if this[1] is the culprit?

[1]: https://hg.mozilla.org/mozilla-central/rev/5533bb014569#l1.15

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1386776 - Beta shouldn't schedule nightly l10n on-push

Review commit: https://reviewboard.mozilla.org/r/164466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164466/

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Tasks taken out from beta on push

Sorry, I'm stealing that bug from you [after I looked at bug 1386995]. 

This patch takes beta from 4035 tasks (after optimization) to 3447. See deleted tasks in here.

The issue was that repackage-signing was scheduling l10n builds/repacks.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8893367 [details]
Bug 1386776 - Beta shouldn't schedule nightly l10n on-push

https://reviewboard.mozilla.org/r/164466/#review169748

Nice solution, I wish I'd have thought of that!

::: taskcluster/taskgraph/target_tasks.py:258
(Diff revision 1)
>  @_target_task('mozilla_beta_tasks')
>  def target_tasks_mozilla_beta(full_task_graph, parameters):
>      """Select the set of tasks required for a promotable beta or release build
>      of linux, plus android CI. The candidates build process involves a pipeline
>      of builds and signing, but does not include beetmover or balrog jobs."""
> +    task_kinds = []

is this used?

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8893367 [details]
Bug 1386776 - Beta shouldn't schedule nightly l10n on-push

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164466/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88fb9218e618
Beta shouldn't schedule nightly l10n on-push r=Callek

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d66f6f6a847

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88fb9218e618

Comment 9

[Johan Lorenzo [:jlorenzo]]

Thanks for the uplift, Ryan!

Comment 10

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/88fb9218e618fab1a8022d0634dd445ff7349109
Bug 1386776 - Beta shouldn't schedule nightly l10n on-push r=Callek