1386863 - Don't notify NotificationProfileDidFinishSyncing when syncing in the background

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement)

Description

[Richard Newman [:rnewman]]

This is a one-line change that will avoid us trying to upload telemetry, invalidate top sites, etc. when we sync on exit.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Can this logic be connected to the SyncReason that we have?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is a pretty good small incremental improvement that we could ship for 8.2 probably.

Comment 3

[Richard Newman [:rnewman]]

(In reply to Stefan Arentz [:st3fan] from comment #1)
> Can this logic be connected to the SyncReason that we have?

Not directly: the only thing we send in the notification is a display state (e.g., in progress, failed).

We could add a reason to that, or we could send a different notification for a background sync.

We use this notification to:

- Update UI from in progress to done (hiding spinners and such).
- Invalidate top sites.

Ideally the UI doesn't need the former if we're backgrounded (most listeners unlink themselves anyway).

I just noticed that we send telemetry in endSyncing, not via notification.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/3003

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed on master, uplifted to v8.x