History and PageMetadata should be joined by History._ID, not History.GUID

NEW
Unassigned

Status

()

Firefox for Android
Data Providers
7 months ago
7 months ago

People

(Reporter: mcomella, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

From Grisha, bug 1386052 comment #6:
> Well, this is unfortunate. I think using history_guid in the pagemetadata
> table was a mistake. It's really a sync-centric field, we won't be syncing
> this data in this shape or form anyway, and so using a local _id field
> likely would have been just fine. As thing stand, without either an
> additional compound select ran after top sites are generated (_id -> guid ->
> metadata), or a what you're proposing as option 1, you can't really
> associate the two tables easily.
In bug 1386052, I'm also adding Combined.HISTORY_GUID to the Combined view (bookmarks & history) and the get top sites temporary table so that the top sites results can be joined with the PageMetadata table: it'd be great to revert these changes.

Comment 2

7 months ago
(In reply to Michael Comella (:mcomella) from comment #1)
> In bug 1386052, I'm also adding Combined.HISTORY_GUID to the Combined view
> (bookmarks & history) and the get top sites temporary table so that the top
> sites results can be joined with the PageMetadata table: it'd be great to
> revert these changes.

Once those changes are in and the immediate problems are addressed, this work starts to feel like unnecessary churn.
You need to log in before you can comment on or make changes to this bug.