1386893 - Make AbstractThread thread safety assertions more generic to work with Quantum DOM cooperative threads

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

AbstractThread has some thread safety assertions that will not work when "main thread" work runs on a pool of cooperative threads. This patch changes the assertions to rely more on nsIEventTarget::IsOnCurrentThread, which understands the cooperative threading model. (It uses GetCurrentVirtualThread() rather than PR_GetCurrentThread() or NS_GetCurrentThread(), which both return a different value for each cooperative thread.)

nsIEventTarget::IsOnCurrentThread should still work at shutdown since it uses PRThreads internally.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8893147 [details] [diff] [review]
patch

Review of attachment 8893147 [details] [diff] [review]:
-----------------------------------------------------------------

Can also remove EventTargetWrapper::mRunningThread. I guess we don't have to fix bug 1323742 anymore when this patch is landed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a41c2b21ee54
Update AbstractThread thread safety assertions to work with cooperative threading (r=jwwang)

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a41c2b21ee54

Comment 4

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/a41c2b21ee54708b3ebd74fbe927824d2e847017
Bug 1386893 - Update AbstractThread thread safety assertions to work with cooperative threading (r=jwwang)