Closed Bug 1386937 Opened 7 years ago Closed 7 years ago

DocumentManager gets initialized multiple times

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(relnote-firefox 55+, firefox55 verified, firefox56 fixed, firefox57 fixed)

VERIFIED FIXED
mozilla57
Tracking Status
relnote-firefox --- 55+
firefox55 --- verified
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

Due to a typo.
https://hg.mozilla.org/mozilla-central/rev/a5dd38359df4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1389381
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1317697
[User impact if declined]: This can cause significant performance issues under certain circumstances after a large number of content scripts have injected into a single content process.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's a simple typo fix that prevents us from reinitializing a singleton class after it's already been initialized.
[String changes made/needed]: None
Attachment #8896460 - Flags: approval-mozilla-release?
Attachment #8896460 - Flags: approval-mozilla-beta?
Comment on attachment 8896460 [details] [diff] [review]
a5dd38359df4811909ea0ec1da7b9cd9bfcd9245.diff

A simple typo fix. Beta56+. Should be in 56.0b3.
Attachment #8896460 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8896460 [details] [diff] [review]
a5dd38359df4811909ea0ec1da7b9cd9bfcd9245.diff

taking it for 55.0.2
Attachment #8896460 - Flags: approval-mozilla-release? → approval-mozilla-release+
Add-on compatibility (webextensions) has been part of our 55.0.2-build1 sign off today. We looked for rendering, functional and performance issues, but we didn't notice any.
Added to the release notes with "Fix performance regressions with WebExtension"
Updating as per comment 8.
Status: RESOLVED → VERIFIED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.