Closed Bug 1386974 Opened 2 years ago Closed 2 years ago

[Firefox for Android] set preference for hardware encoder to true in default

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 + fixed
firefox57 --- fixed

People

(Reporter: mchiang, Assigned: mchiang)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

We have got sign-off from SoftwareVision.
We will turn on hardware encoder as default in 56.
Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

https://reviewboard.mozilla.org/r/164306/#review169744
Attachment #8893265 - Flags: review?(jib) → review+
Assignee: nobody → mchiang
I think this is for 57 at this point, right?
Flags: needinfo?(mchiang)
Or are we planning to land for 56 (having been on in Nightly)?
We plan to land for 56.
Flags: needinfo?(mchiang)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a3061347739b
set the preference for android hardware encoder to true in default. r=jib
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a3061347739b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

Approval Request Comment
[Feature/Bug causing the regression]:Not regression
[User impact if declined]:hardware encoder won't be enabled in 56 as planned. 
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]:no, SoftwareVision already performed the manual test. 
[List of other uplifts needed for the feature/fix]:n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: SoftwareVision tested quite a few android devices and the result is positive.
[String changes made/needed]:no
Attachment #8893265 - Flags: approval-mozilla-beta?
Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

Planned release of android feature, let's uplift for 56 beta 1.
Attachment #8893265 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Added the note that this has been enabled to Firefox 56 for developers.
You need to log in before you can comment on or make changes to this bug.