1386974 - [Firefox for Android] set preference for hardware encoder to true in default

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

We have got sign-off from SoftwareVision.
We will turn on hardware encoder as default in 56.

Comment 1

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Attachment: Bug 1386974 - set the preference for android hardware encoder to true in default.

Review commit: https://reviewboard.mozilla.org/r/164306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164306/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

https://reviewboard.mozilla.org/r/164306/#review169744

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I think this is for 57 at this point, right?

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Or are we planning to land for 56 (having been on in Nightly)?

Comment 5

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

We plan to land for 56.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3061347739b
set the preference for android hardware encoder to true in default. r=jib

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a3061347739b

Comment 8

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

Approval Request Comment
[Feature/Bug causing the regression]:Not regression
[User impact if declined]:hardware encoder won't be enabled in 56 as planned. 
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]:no, SoftwareVision already performed the manual test. 
[List of other uplifts needed for the feature/fix]:n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: SoftwareVision tested quite a few android devices and the result is positive.
[String changes made/needed]:no

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8893265 [details]
Bug 1386974 - set the preference for android hardware encoder to true in default.

Planned release of android feature, let's uplift for 56 beta 1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5ae0367e5f0

Comment 11

[Eric Shepherd [:sheppy]]

Added the note that this has been enabled to Firefox 56 for developers.