Per the email thread discussion, we should considering disabling the one-touch-pinch feature in 55 release while we polish it a bit more.
Created attachment 8893430 [details] [diff] [review] Disable one-touch-pinch Approval Request Comment [Feature/Bug causing the regression]: New zoom gesture introduced in bug 1111333 [User impact if declined]: Andreas Bovens reports that in some cases the feature feels buggy/unpolished. It's true that we probably haven't gotten as much user testing of this feature as we would like as it's not a very discoverable gesture and we have low pre-release user populations anyway [Is this code covered by automated tests?]: not particularly [Has the fix been verified in Nightly?]: no, requesting disabling the pref on release only for now [Needs manual test from QE? If yes, steps to reproduce]: yes. try using the gesture with the pref disabled [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: not really [Why is the change risky/not risky?]: just a pref flip. the code it covers is also relatively small and self-contained. [String changes made/needed]: none
Assignee: nobody → bugmail
Attachment #8893430 - Flags: approval-mozilla-release?
Comment on attachment 8893430 [details] [diff] [review] Disable one-touch-pinch ok, let's take it in rc3
Attachment #8893430 - Flags: approval-mozilla-release? → approval-mozilla-release+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
status-firefox56: --- → wontfix
status-firefox57: --- → wontfix
tracking-firefox55: --- → ?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Our Play Store release notes still mention this feature - maybe they should mirror https://www.mozilla.org/en-US/firefox/android/55.0/releasenotes/ and mention bug 1331154 instead?
Delphine, could you please remove it from the 55 release notes? I hope it will show immediately here: https://l10n.mozilla-community.org/stores_l10n/product/fx_android/release/whatsnew/raw/ and I will be able to upload it right away
Flags: needinfo?(sledru) → needinfo?(lebedel.delphine)
Thanks Sylvestre. We're traveling to Paraguay now and are trying to get around the bad connection. Flod's on it as he can directly push the changes. Will let you know.
Updated. It might seem obvious from the discussion, but it helps to mention the exact words to be removed, I had a hard time matching "one-touch-pinch" with "Double tap and drag gesture allows one-handed zooming, consistent with other Android applications".
worked great, just a small bug that I reported here: https://github.com/mozilla-l10n/stores_l10n/issues/145 We should not have the string in a few minutes.
You need to log in before you can comment on or make changes to this bug.