Remove code to automatically add sidebar button to the navbar when the user installs a sidebar add-on

RESOLVED FIXED in Firefox 58

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
mozilla58
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(1 attachment)

Assignee

Description

2 years ago
The button is now in the default set, so if it's not in the navbar the user has consciously removed it. We only ever added the button once, and now adding it twice doesn't seem too useful. Relevant code:

https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/browser/components/extensions/ext-sidebarAction.js#128-136
Flags: qe-verify-
Priority: -- → P3
Priority: P3 → P4
Priority: P4 → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: P3 → P1

Comment 2

2 years ago
mozreview-review
Comment on attachment 8926453 [details]
Bug 1387081 - stop re-adding the sidebar button to the toolbar now that it's there by default,

https://reviewboard.mozilla.org/r/197704/#review202926
Attachment #8926453 - Flags: review?(mixedpuppy) → review+

Comment 3

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1f5043322c88
stop re-adding the sidebar button to the toolbar now that it's there by default, r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/1f5043322c88
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

11 months ago
Product: Toolkit → WebExtensions

Updated

10 months ago
Blocks: 1480993
You need to log in before you can comment on or make changes to this bug.