Closed Bug 1387081 Opened 4 years ago Closed 4 years ago

Remove code to automatically add sidebar button to the navbar when the user installs a sidebar add-on

Categories

(WebExtensions :: General, enhancement, P1)

enhancement

Tracking

(firefox57 wontfix, firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(1 file)

The button is now in the default set, so if it's not in the navbar the user has consciously removed it. We only ever added the button once, and now adding it twice doesn't seem too useful. Relevant code:

https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/browser/components/extensions/ext-sidebarAction.js#128-136
Flags: qe-verify-
Priority: -- → P3
Priority: P3 → P4
Priority: P4 → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8926453 [details]
Bug 1387081 - stop re-adding the sidebar button to the toolbar now that it's there by default,

https://reviewboard.mozilla.org/r/197704/#review202926
Attachment #8926453 - Flags: review?(mixedpuppy) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1f5043322c88
stop re-adding the sidebar button to the toolbar now that it's there by default, r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/1f5043322c88
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Toolkit → WebExtensions
Blocks: 1480993
You need to log in before you can comment on or make changes to this bug.