1387081 - Remove code to automatically add sidebar button to the navbar when the user installs a sidebar add-on

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[:Gijs (out for now; he/him)]

The button is now in the default set, so if it's not in the navbar the user has consciously removed it. We only ever added the button once, and now adding it twice doesn't seem too useful. Relevant code:

https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/browser/components/extensions/ext-sidebarAction.js#128-136

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1387081 - stop re-adding the sidebar button to the toolbar now that it's there by default,

Review commit: https://reviewboard.mozilla.org/r/197704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197704/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8926453 [details]
Bug 1387081 - stop re-adding the sidebar button to the toolbar now that it's there by default,

https://reviewboard.mozilla.org/r/197704/#review202926

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f5043322c88
stop re-adding the sidebar button to the toolbar now that it's there by default, r=mixedpuppy

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1f5043322c88