1387199 - Windows SM builds

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Justin Wood (:Callek)]

Schedule/build windows spidermonkey on taskcluster

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.

Review commit: https://reviewboard.mozilla.org/r/169386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169386/

Comment 2

[Justin Wood (:Callek)]

Attachment: Bug 1387199 - Do spidermonkey windows in taskgraph.

Review commit: https://reviewboard.mozilla.org/r/169388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169388/

Comment 3

[Justin Wood (:Callek)]

A try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1a16e207d345898f5ce20b9251231185e6081ea&filter-searchStr=SM

I'm suspecting theres some issue with SM-tc(cgc) here, so will look into that if so, and I manually triggered new jobs for all Buildbot runs, (try's add new jobs suggested w64 and an opt copy of cgc, even though none of those seem to be running on m-c, so not sure if they will even run)

If there is more followups I'll update this patchset, but wanted to get the patches that exist out for review.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8898076 [details]
Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169386/diff/1-2/

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8898077 [details]
Bug 1387199 - Do spidermonkey windows in taskgraph.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169388/diff/1-2/

Comment 6

[Justin Wood (:Callek)]

Latest try run is https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc199105bfbe0d7ff774bf11c5150fae4e1b7c8e&filter-searchStr=sm I see some intermittent tests so I retriggered stuff a bunch.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8898076 [details]
Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.

https://reviewboard.mozilla.org/r/169386/#review175066

I'm not sure why this would be necesary, but I'm not really familiar with this setup.

Comment 8

[Justin Wood (:Callek)]

(In reply to Chris Manchester (:chmanchester) from comment #7)
> Comment on attachment 8898076 [details]
> Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.
> 
> https://reviewboard.mozilla.org/r/169386/#review175066
> 
> I'm not sure why this would be necesary, but I'm not really familiar with
> this setup.

Without doing this, for some reason VSPATH was not being found in my initial runs, once I started exporting it, things seemed to work.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8898077 [details]
Bug 1387199 - Do spidermonkey windows in taskgraph.

https://reviewboard.mozilla.org/r/169388/#review175138

::: taskcluster/taskgraph/transforms/job/spidermonkey.py:116
(Diff revision 2)
> +    if run['using'] == 'spidermonkey-package':
> +        script = "build-sm-package.sh"
> +        raise Exception("Really?")
> +    elif run['using'] == 'spidermonkey-mozjs-crate':
> +        script = "build-sm-mozjs-crate.sh"
> +        raise Exception("Really?")

what does this mean (and again just above)

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8898076 [details]
Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.

https://reviewboard.mozilla.org/r/169386/#review175358

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 8898076 [details]
Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169386/diff/2-3/

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8898077 [details]
Bug 1387199 - Do spidermonkey windows in taskgraph.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169388/diff/2-3/

Comment 13

[Justin Wood (:Callek)]

Comment on attachment 8898076 [details]
Bug 1387199 - Spidermonkey export VSPATH for taskcluster windows support.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169386/diff/3-4/

Comment 14

[Justin Wood (:Callek)]

Comment on attachment 8898077 [details]
Bug 1387199 - Do spidermonkey windows in taskgraph.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169388/diff/3-4/

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 8898077 [details]
Bug 1387199 - Do spidermonkey windows in taskgraph.

https://reviewboard.mozilla.org/r/169388/#review175138

> what does this mean (and again just above)

It means I forgot to flesh out the error, its mostly just a "I didn't test this configuration that is supported on linux".

Comment 16

[Justin Wood (:Callek)]

Unlike what was reviewed, I'm landing this as tier 3 because I feel the testing that was present is too flaky, but I wanted to get this into the tree so that others can look at those issues earlier.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/febdade6a6e2
Spidermonkey export VSPATH for taskcluster windows support. r=gps
https://hg.mozilla.org/integration/autoland/rev/31c71a0e4e31
Do spidermonkey windows in taskgraph. r=dustin

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/febdade6a6e2
https://hg.mozilla.org/mozilla-central/rev/31c71a0e4e31