Editor instance should be referred/stored as concrete class as far as possible part2

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

(Blocks 1 bug)

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(5 attachments)

+++ This bug was initially created as a clone of Bug #1374207 +++

nsIEditor and other related interfaces will be builtin classes after fixing bug 1060051.  Then, all editor instances are guaranteed that the instances are TextEditor or HTMLEditor.  Then, we can reduce a lot of virtual calls with accessing them via pointer to concrete class.
Summary: Editor instance should be referred/stored as concrete class as far as possible → Editor instance should be referred/stored as concrete class as far as possible part2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8897278 [details]
Bug 1387317 - part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor

https://reviewboard.mozilla.org/r/168570/#review173898
Attachment #8897278 - Flags: review?(m_kato) → review+
Comment on attachment 8897279 [details]
Bug 1387317 - part2: EditorEventListener should stop using interface methods as far as possible

https://reviewboard.mozilla.org/r/168572/#review173938
Attachment #8897279 - Flags: review?(m_kato) → review+
Comment on attachment 8897280 [details]
Bug 1387317 - part3: HTMLEditor should use RefPtr<HTMLEditor> rather than nsCOMPtr<nsIHTMLEditor> for kungFuDeathGrip

https://reviewboard.mozilla.org/r/168574/#review173940
Attachment #8897280 - Flags: review?(m_kato) → review+
Comment on attachment 8897281 [details]
Bug 1387317 - part4: Make editor flag setters use new AddFlags() or RemoveFlags() if useful

https://reviewboard.mozilla.org/r/168576/#review173944
Attachment #8897281 - Flags: review?(m_kato) → review+
Comment on attachment 8897282 [details]
Bug 1387317 - part5: AutoPlaceHolderBatch should take EditorBase instead of nsIEditor

https://reviewboard.mozilla.org/r/168578/#review173956
Attachment #8897282 - Flags: review?(m_kato) → review+

Comment 15

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c88f2794e675
part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor r=m_kato
https://hg.mozilla.org/integration/autoland/rev/eda3fcc1e872
part2: EditorEventListener should stop using interface methods as far as possible r=m_kato
https://hg.mozilla.org/integration/autoland/rev/052c275f3166
part3: HTMLEditor should use RefPtr<HTMLEditor> rather than nsCOMPtr<nsIHTMLEditor> for kungFuDeathGrip r=m_kato
https://hg.mozilla.org/integration/autoland/rev/de61ab519b71
part4: Make editor flag setters use new AddFlags() or RemoveFlags() if useful r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b131a336d02f
part5: AutoPlaceHolderBatch should take EditorBase instead of nsIEditor r=m_kato
You need to log in before you can comment on or make changes to this bug.