Closed
Bug 1387317
Opened 7 years ago
Closed 7 years ago
Editor instance should be referred/stored as concrete class as far as possible part2
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
Bug 1387317 - part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
+++ This bug was initially created as a clone of Bug #1374207 +++ nsIEditor and other related interfaces will be builtin classes after fixing bug 1060051. Then, all editor instances are guaranteed that the instances are TextEditor or HTMLEditor. Then, we can reduce a lot of virtual calls with accessing them via pointer to concrete class.
Assignee | ||
Updated•7 years ago
|
Summary: Editor instance should be referred/stored as concrete class as far as possible → Editor instance should be referred/stored as concrete class as far as possible part2
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9be7f9b8efb17e488ae8b1c26e8c8dbaebf74168
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=366a303a745c1e88a3e33e1a7dfa89abe31ef676
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e0c6bbdbce151014bc8169969dbb1c9329f89f5
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74088e9bceb64be8903e6c09fc135290af1dd512
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8897278 [details] Bug 1387317 - part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor https://reviewboard.mozilla.org/r/168570/#review173898
Attachment #8897278 -
Flags: review?(m_kato) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8897279 [details] Bug 1387317 - part2: EditorEventListener should stop using interface methods as far as possible https://reviewboard.mozilla.org/r/168572/#review173938
Attachment #8897279 -
Flags: review?(m_kato) → review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8897280 [details] Bug 1387317 - part3: HTMLEditor should use RefPtr<HTMLEditor> rather than nsCOMPtr<nsIHTMLEditor> for kungFuDeathGrip https://reviewboard.mozilla.org/r/168574/#review173940
Attachment #8897280 -
Flags: review?(m_kato) → review+
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8897281 [details] Bug 1387317 - part4: Make editor flag setters use new AddFlags() or RemoveFlags() if useful https://reviewboard.mozilla.org/r/168576/#review173944
Attachment #8897281 -
Flags: review?(m_kato) → review+
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8897282 [details] Bug 1387317 - part5: AutoPlaceHolderBatch should take EditorBase instead of nsIEditor https://reviewboard.mozilla.org/r/168578/#review173956
Attachment #8897282 -
Flags: review?(m_kato) → review+
Comment 15•7 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/c88f2794e675 part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor r=m_kato https://hg.mozilla.org/integration/autoland/rev/eda3fcc1e872 part2: EditorEventListener should stop using interface methods as far as possible r=m_kato https://hg.mozilla.org/integration/autoland/rev/052c275f3166 part3: HTMLEditor should use RefPtr<HTMLEditor> rather than nsCOMPtr<nsIHTMLEditor> for kungFuDeathGrip r=m_kato https://hg.mozilla.org/integration/autoland/rev/de61ab519b71 part4: Make editor flag setters use new AddFlags() or RemoveFlags() if useful r=m_kato https://hg.mozilla.org/integration/autoland/rev/b131a336d02f part5: AutoPlaceHolderBatch should take EditorBase instead of nsIEditor r=m_kato
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c88f2794e675 https://hg.mozilla.org/mozilla-central/rev/eda3fcc1e872 https://hg.mozilla.org/mozilla-central/rev/052c275f3166 https://hg.mozilla.org/mozilla-central/rev/de61ab519b71 https://hg.mozilla.org/mozilla-central/rev/b131a336d02f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•