Closed Bug 1387320 Opened 2 years ago Closed 2 years ago

Port Bug 1322874 to mailnews: Get rid of nsIURI.originCharset

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: jorgk)

Details

Attachments

(1 file, 1 obsolete file)

Getting this bustage:

20:24.98 nsAddbookUrl.cpp
20:24.98 e:/mozstuff/comm/trees/c-c/mailnews/addrbook/src/nsAddbookUrl.cpp(170): error C2039: 'GetOriginCharset': is not a member of 'nsAddbookUrl'
20:24.98 e:\mozstuff\comm\trees\c-c\mailnews\addrbook\src\nsAddbookUrl.h(13): note: see declaration of 'nsAddbookUrl'
20:24.98 e:/mozstuff/comm/trees/c-c/mailnews/addrbook/src/nsAddbookUrl.cpp(172): error C2065: 'm_baseURL': undeclared identifier
20:24.98 e:/mozstuff/comm/trees/c-c/mailnews/addrbook/src/nsAddbookUrl.cpp(172): error C2227: left of '->GetOriginCharset' must point to class/struct/union/generic type
20:24.98 e:/mozstuff/comm/trees/c-c/mailnews/addrbook/src/nsAddbookUrl.cpp(172): note: type is 'unknown-type'
20:24.99 e:/mozstuff/comm/trees/c-c/mozilla/config/rules.mk:1050: recipe for target 'nsAddbookUrl.obj' failed
20:24.99 mozmake.EXE[4]: *** [nsAddbookUrl.obj] Error 2
20:24.99 e:/mozstuff/comm/trees/c-c/mozilla/config/recurse.mk:73: recipe for target 'mailnews/addrbook/src/target' failed
20:24.99 mozmake.EXE[3]: *** [mailnews/addrbook/src/target] Error 2
20:24.99 mozmake.EXE[3]: *** Waiting for unfinished jobs....
https://hg.mozilla.org/mozilla-central/rev/8ff32bdb356d
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Summary: GetOriginCharset is not a member of nsAddbookUrl → Port Bug 1322874 to mailnews: Get rid of nsIURI.originCharset
Attached patch 1387320-originCharset.patch (v1) (obsolete) — Splinter Review
This should compile, but there are more changes necessary:

Services.io.newURI() lost the second charset parameter, which we use in
editor/ui/composer/content/ComposerCommands.js
editor/ui/composer/content/editorUtilities.js
Masatoshi-san, should we remove the charset here?
https://dxr.mozilla.org/comm-central/source/editor/ui/composer/content/ComposerCommands.js#823 (and more in that file)
https://dxr.mozilla.org/comm-central/source/editor/ui/composer/content/editorUtilities.js#540 (and more in that file)

nsIIOService.newURI() still takes the argument.
Flags: needinfo?(VYV03354)
The second parameter of nsIIOService.newURI() still has an effect. Please do not remove them as long as the charset is easily available.
Flags: needinfo?(VYV03354)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6ee221481c59
Port bug 1322874 to mailnews: Remove nsIURI.originCharset, implement SetQueryWithEncoding(). rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Attachment #8893686 - Attachment is obsolete: true
(In reply to Masatoshi Kimura [:emk] from comment #4)
> The second parameter of nsIIOService.newURI() still has an effect. Please do
> not remove them as long as the charset is easily available.
OK, I didn't ;-)
You need to log in before you can comment on or make changes to this bug.