Closed Bug 1387335 Opened 7 years ago Closed 7 years ago

Splinter reviews / BMO comments truncated at certain unicode/utf-8 characters - review dataloss!

Categories

(bugzilla.mozilla.org :: Splinter, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1253535

People

(Reporter: thomas8, Unassigned)

Details

STR 1) On BMO attachment, click [review] for Splinter review 2) Add overview comment: "Hello world, unicode world symbol and review follows" 3) Add review of code containing unicode characters like 1F4D8 (book symbol: https://apps.timwhitlock.info/unicode/inspect/hex/1F4D8) 1F30D (world symbol: https://apps.timwhitlock.info/unicode/inspect/hex/1F30D) Copy the actual characters into your review 4) Continue writing up lots of review comments: "More text after unicode symbols" 5) Publish Actual result Review gets truncated at the first unicode character (1F4D8). Any review comments after that character are gone for good ("More text after unicode symbols" is not seen). Curse BMO!!! I.e. your entire review has gone down the drain, without warning, and without any way of recovery. That's massive dataloss. Expected result BMO must not destroy my review!!! Any text which displays correctly when entered must be preserved in the review, so those unicode characters should just show up correctly in the published review. Otherwise warn user (before, during, or at least after entering such characters) and offer ways of recovery. FYI: Regular BMO comments are also affected, comment truncated at first unicode character. Dataloss for comments again. Probably related.
This happens because mysql is not configured to handle real utf8, unfortunately. There is no technical reason for this to persist, it is just a matter of needing database downtime to do the conversion, with the very minor step of making sure BMO is aware that tables should be created with utf8mb4. It is *possible* to mitigate this in the application level, but I think that would be a misuse of resources (= developer time).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
I'm really sorry for this still being a problem, I'm pushing towards a resolution in bug 1253535.
Thanks a lot Dylan for fast, informative, and sympathetic feedback, plus your agility towards fixing this. That's great service, and good news.
You need to log in before you can comment on or make changes to this bug.