Closed
Bug 1387356
Opened 6 years ago
Closed 6 years ago
Remove deprecated fireSidebarFocusedEvent, sidebarOnLoad, toggleSidebar functions
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: dao, Assigned: adrian17)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
These aren't needed anymore: http://searchfox.org/mozilla-central/rev/30a47c4339bd397b937abdb2305f99d3bb537ba6/browser/base/content/browser-sidebar.js#437-469
|
Assignee | |
Comment 1•6 years ago
|
||
Hi, I am willing to take this bug (in fact, I have a patch ready). I don't know who should be the reviewer, though. Also, how much automated testing should I run for this kind of cleanup? I ran eslint and mochitest on `browser/base/content/test/sidebar/`.
Flags: needinfo?(dao+bmo)
|
Reporter | |
Comment 2•6 years ago
|
||
Hi! I can review the patch. I don't think you need to run tests for this. You can use searchfox.org to verify that these functions are never called.
Flags: needinfo?(dao+bmo)
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904326 [details] Bug 1387356 - Remove deprecated sidebar functions. https://reviewboard.mozilla.org/r/176102/#review181186 Thanks!
Attachment #8904326 -
Flags: review?(dao+bmo) → review+
|
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → adrian.wielgosik
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d2fb90da236 Remove deprecated sidebar functions. r=dao
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9d2fb90da236
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•