Closed Bug 1387356 Opened 3 years ago Closed 3 years ago

Remove deprecated fireSidebarFocusedEvent, sidebarOnLoad, toggleSidebar functions

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: dao, Assigned: adrian17)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

Hi,

I am willing to take this bug (in fact, I have a patch ready). I don't know who should be the reviewer, though.

Also, how much automated testing should I run for this kind of cleanup? I ran eslint and mochitest on `browser/base/content/test/sidebar/`.
Flags: needinfo?(dao+bmo)
Hi! I can review the patch. I don't think you need to run tests for this. You can use searchfox.org to verify that these functions are never called.
Flags: needinfo?(dao+bmo)
Comment on attachment 8904326 [details]
Bug 1387356 - Remove deprecated sidebar functions.

https://reviewboard.mozilla.org/r/176102/#review181186

Thanks!
Attachment #8904326 - Flags: review?(dao+bmo) → review+
Assignee: nobody → adrian.wielgosik
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d2fb90da236
Remove deprecated sidebar functions. r=dao
https://hg.mozilla.org/mozilla-central/rev/9d2fb90da236
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.