Remove deprecated fireSidebarFocusedEvent, sidebarOnLoad, toggleSidebar functions

RESOLVED FIXED in Firefox 57

Status

()

Firefox
General
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: dao, Assigned: Adrian Wielgosik)

Tracking

(Blocks: 1 bug, {good-first-bug})

Trunk
Firefox 57
good-first-bug
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [good first bug][lang=js])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
These aren't needed anymore:

http://searchfox.org/mozilla-central/rev/30a47c4339bd397b937abdb2305f99d3bb537ba6/browser/base/content/browser-sidebar.js#437-469
(Assignee)

Comment 1

3 months ago
Hi,

I am willing to take this bug (in fact, I have a patch ready). I don't know who should be the reviewer, though.

Also, how much automated testing should I run for this kind of cleanup? I ran eslint and mochitest on `browser/base/content/test/sidebar/`.
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 2

2 months ago
Hi! I can review the patch. I don't think you need to run tests for this. You can use searchfox.org to verify that these functions are never called.
Flags: needinfo?(dao+bmo)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 months ago
mozreview-review
Comment on attachment 8904326 [details]
Bug 1387356 - Remove deprecated sidebar functions.

https://reviewboard.mozilla.org/r/176102/#review181186

Thanks!
Attachment #8904326 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

2 months ago
Assignee: nobody → adrian.wielgosik

Comment 5

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d2fb90da236
Remove deprecated sidebar functions. r=dao
https://hg.mozilla.org/mozilla-central/rev/9d2fb90da236
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Blocks: 1394207
You need to log in before you can comment on or make changes to this bug.