1387385 - Remove usage of nsIJSON from Web Payments

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement)

Description

[Henri Sivonen (:hsivonen)]

https://searchfox.org/mozilla-central/source/dom/payments/PaymentRequestUtils.cpp depends on nsIJSON.

Note how nsIJSON.idl says: "Don't use this!"

Please remove the nsIJSON dependency so that nsIJSON can be removed from the code base.

Comment 1

[Eden Chuang[:edenchuang]]

I will remove nsIJSON from payment implementation.

Comment 2

[Eden Chuang[:edenchuang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b8a22fc13c73315412004e4b50ffc447f8e0d85

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1387385 - Remove nsIJSON in web payment.

Comment 4

[Eden Chuang[:edenchuang]]

Attachment: Bug 1387385 - Bug 1387385 - Remove all nsIJSON usage in PaymentRequestUtils.cpp. r?baku

Remove all nsIJSON from PaymentRequestUtils.cpp

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8899660 [details] [diff] [review]
Bug 1387385 - Bug 1387385 - Remove all nsIJSON usage in PaymentRequestUtils.cpp. r?baku

Review of attachment 8899660 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/payments/PaymentRequestUtils.cpp
@@ +28,2 @@
>    JS::RootedValue value(aCx, JS::ObjectValue(*aObject));
> +  JS::HandleValue handleVal(&value);

This is wrong. You just need to pass &value to SerializeFromJSVal.

Comment 6

[Eden Chuang[:edenchuang]]

Attachment: Bug 1387385 - Remove all nsIJSON usage from PaymentRequestUtils.cpp. r?baku

Modify the patch according to comment 5, but got following compile error when passing &value to SerializeFromJSVal.

13:27.69 /Volumes/fxos_workspace/gecko/mozilla-central/dom/payments/PaymentRequestUtils.cpp:29:10: error: no matching function for call to 'SerializeFromJSVal'
13:27.70   return SerializeFromJSVal(aCx, &value, aSerializedObject);
13:27.70          ^~~~~~~~~~~~~~~~~~
13:27.70 /Volumes/fxos_workspace/gecko/mozilla-central/dom/payments/PaymentRequestUtils.h:22:1: note: candidate function not viable: no known conversion from 'JS::RootedValue *' (aka 'Rooted<JS::Value> *') to 'JS::HandleValue' (aka 'Handle<JS::Value>') for 2nd argument

I guess that we should pass "value" here not "&value".
Passing "value" makes both build and mochitest pass, so I use "value" in this patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80622cca7657
Remove all nsIJSON usage in PaymentRequestUtils.cpp. r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80622cca7657