1387388 - Also enable -Wno-implicit-fallthrough when building jsdtoa.cpp (exists now with gcc 7)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

Now that gcc 7 supports -Wno-implicit-fallthrough, we should use it for js/src/jsdtoa.cpp

Otherwise:
 0:33.87 In file included from /root/firefox-gcc-last/js/src/jsdtoa.cpp:65:0:
 0:33.87 /root/firefox-gcc-last/js/src/dtoa.c: In function 'double _strtod(DtoaState*, const char*, char**)':
 0:33.87 /root/firefox-gcc-last/js/src/dtoa.c:1520:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
 0:33.87     sign = 1;
 0:33.87     ~~~~~^~~

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1387388 - Disable -Wimplicit-fallthrough when building jsdtoa.cpp (exists now with gcc 7)

Review commit: https://reviewboard.mozilla.org/r/164864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164864/

Comment 2

[Nicolas B. Pierron [:nbp | PTO until 11/11]]

Comment on attachment 8893759 [details]
Bug 1387388 - Disable -Wimplicit-fallthrough when building jsdtoa.cpp (exists now with gcc 7)

https://reviewboard.mozilla.org/r/164864/#review170736

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a14375fa041
Disable -Wimplicit-fallthrough when building jsdtoa.cpp (exists now with gcc 7) r=nbp

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a14375fa041