138741 - Inline functions in jsdtoa.c for performance

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Bratell]

Measurements in bug 120992 shows that we can improve performance in jsdtoa.c by
~10% just by inlining free and cmp. This probably has compatibility problems.
Inline didn't appear in the C standard until C99.

Comment 1

[Brendan Eich [:brendan]]

Go fast, maybe this will prove good for 1.0.

/be

Comment 2

[Adam D. Moss]

n.b. it's easy to #define inline away to the
empty string for compilers that don't support it.
(I imagine there's already an autoconf macro for
detecting and pretty much doing that.)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

yup, there is an autoconf macro, AC_C_INLINE
it defines "inline" to whatever the compiler understands for inlining functions 
or to nothing if inlining isn't supported.

Comment 4

[Mike Kaply [:mkaply]]

AC_C_INLINE Doesn't appear to work.

Chris Seawood, know of anyway to autodetect inline?

Comment 5

[Mike Kaply [:mkaply]]

There is some code in glibidl configure.in that does what we need sort of:

http://lxr.mozilla.org/seamonkey/source/xpcom/typelib/xpidl/glib/glib-1.2.1/configure.in#209

Comment 6

[Brian Crowder]

Grabbing this since I have a recent interest in jsdtoa.c and it makes me sad that this bug didn't go anywhere.

Comment 7

[Brian Crowder]

Some of this was fixed by my dtoa.c work last year, and the rest should be followed-up elsewhere.