make grid-row-gap and grid-column-gap no longer be reset by the grid shorthand

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dbaron, Assigned: emilio)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments)

In https://github.com/w3c/csswg-drafts/issues/1036 the CSSWG just decided that grid-row-gap and grid-column-gap should not be reset by the grid shorthand.

This has a bit of compatibility risk, but probably better to try sooner rather than later.  Apparently the grid *shorthand* isn't used much yet.

We should also track implementation plans in other implementations.
(In reply to David Baron :dbaron: ⌚️UTC-4 (away September 4-8) from comment #0)
> In https://github.com/w3c/csswg-drafts/issues/1036 the CSSWG just decided
> that grid-row-gap and grid-column-gap should not be reset by the grid
> shorthand.
> 
> This has a bit of compatibility risk, but probably better to try sooner
> rather than later.  Apparently the grid *shorthand* isn't used much yet.
> 
> We should also track implementation plans in other implementations.

This has just been fixed in Blink and WebKit,
it'd be nice if Firefox can update the behavior too.
Links:
* Blink: https://bugs.chromium.org/p/chromium/issues/detail?id=761905
* WebKit: https://bugs.webkit.org/show_bug.cgi?id=176375
(Assignee)

Comment 3

a year ago
Thanks for the heads-up Rego. I guess I can take it, should be trivial.
Assignee: nobody → emilio
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Also Edge seems to have updated their implementation too:
https://twitter.com/gregwhitworth/status/905460683818524672

Thanks for working on this Emilio.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

a year ago
mozreview-review
Comment on attachment 8905090 [details]
Bug 1387410: Stop the grid shorthand from resetting grid-gap properties.

https://reviewboard.mozilla.org/r/176892/#review182602
Attachment #8905090 - Flags: review?(cam) → review+

Comment 12

a year ago
mozreview-review
Comment on attachment 8905091 [details]
Bug 1387410: Regenerate the properties database.

https://reviewboard.mozilla.org/r/176894/#review182604
Attachment #8905091 - Flags: review?(cam) → review+
(Assignee)

Comment 13

a year ago
Err, forgot that the servo bits need to go through the long path, sigh.

Comment 14

a year ago
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 10 changes to 10 files
remote: (e1e170a52677 modifies servo/components/style/properties/shorthand/position.mako.rs from Servo; not enforcing peer review)
remote: (1 changesets contain changes to protected servo/ directory: e1e170a52677)
remote: ************************************************************************
remote: you do not have permissions to modify files under servo/
remote: 
remote: the servo/ directory is kept in sync with the canonical upstream
remote: repository at https://github.com/servo/servo
remote: 
remote: changes to servo/ are only allowed by the syncing tool and by sheriffs
remote: performing cross-repository "merges"
remote: 
remote: to make changes to servo/, submit a Pull Request against the servo/servo
remote: GitHub project
remote: ************************************************************************
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.e_prevent_vendored hook failed
abort: push failed on remote
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 18

a year ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/23a9ea8f5b16
Stop the grid shorthand from resetting grid-gap properties. r=heycam
https://hg.mozilla.org/integration/autoland/rev/10bbe3749f10
Regenerate the properties database. r=heycam

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/23a9ea8f5b16
https://hg.mozilla.org/mozilla-central/rev/10bbe3749f10
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.