Stylo: Audit skipped DevTools tests

RESOLVED FIXED in Firefox 57

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
Some DevTools tests are currently skipped on Stylo.  Let's ensure we get these all back up to parity.
(Assignee)

Updated

11 months ago
Keywords: leave-open
For the failure of `browser_rules_custom.js`[1], I analyzed the test case and filed bug 1391198 for it.

[1]: https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/test/browser_rules_custom.js

Comment 2

10 months ago
Ryan, I'm picking up bugs. Feel free to assign this one to me.

Comment 3

10 months ago
Ryan was going to look at this today and make this more actionable.
Flags: needinfo?(jryans)
(Assignee)

Comment 4

10 months ago
Okay, I've filed specific bugs and have a patch to update annotations for devtools/client/inspector/rules.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3df7528bec9ebd6968c2c6f3c9fe7cad303a884

I also want to check on RDM, so I'll look at that tomorrow.
(Assignee)

Comment 6

10 months ago
Okay, looks like the rules annotation updates are okay:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed5e4082a420a5f8cb3238145285326066e92abe

and also the RDM updates:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78e4421a28af4aa94d11d3fba95ede9ac1fc9d0f
Flags: needinfo?(jryans)
Keywords: leave-open
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

10 months ago
mozreview-review
Comment on attachment 8902752 [details]
Bug 1387445 - Update Stylo DevTools annotations.

https://reviewboard.mozilla.org/r/174406/#review179752
Attachment #8902752 - Flags: review?(xidorn+moz) → review+

Comment 10

10 months ago
mozreview-review
Comment on attachment 8902753 [details]
Bug 1387445 - Enable DevTools RDM tests on Linux debug.

https://reviewboard.mozilla.org/r/174408/#review179754
Attachment #8902753 - Flags: review?(xidorn+moz) → review+

Comment 11

10 months ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349be74f60cd
Update Stylo DevTools annotations. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/80c7e2729fc9
Enable DevTools RDM tests on Linux debug. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/349be74f60cd
https://hg.mozilla.org/mozilla-central/rev/80c7e2729fc9
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.