Closed Bug 1387445 Opened 7 years ago Closed 7 years ago

Stylo: Audit skipped DevTools tests

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(2 files)

Some DevTools tests are currently skipped on Stylo.  Let's ensure we get these all back up to parity.
For the failure of `browser_rules_custom.js`[1], I analyzed the test case and filed bug 1391198 for it.

[1]: https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/test/browser_rules_custom.js
Ryan, I'm picking up bugs. Feel free to assign this one to me.
Ryan was going to look at this today and make this more actionable.
Flags: needinfo?(jryans)
Okay, I've filed specific bugs and have a patch to update annotations for devtools/client/inspector/rules.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3df7528bec9ebd6968c2c6f3c9fe7cad303a884

I also want to check on RDM, so I'll look at that tomorrow.
Comment on attachment 8902752 [details]
Bug 1387445 - Update Stylo DevTools annotations.

https://reviewboard.mozilla.org/r/174406/#review179752
Attachment #8902752 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8902753 [details]
Bug 1387445 - Enable DevTools RDM tests on Linux debug.

https://reviewboard.mozilla.org/r/174408/#review179754
Attachment #8902753 - Flags: review?(xidorn+moz) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349be74f60cd
Update Stylo DevTools annotations. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/80c7e2729fc9
Enable DevTools RDM tests on Linux debug. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/349be74f60cd
https://hg.mozilla.org/mozilla-central/rev/80c7e2729fc9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: