1387445 - Stylo: Audit skipped DevTools tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Some DevTools tests are currently skipped on Stylo.  Let's ensure we get these all back up to parity.

Comment 1

[Chih-Hsuan Kuo [:tommykuo]]

For the failure of `browser_rules_custom.js`[1], I analyzed the test case and filed bug 1391198 for it.

[1]: https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/test/browser_rules_custom.js

Comment 2

[Brad Werth [:bradwerth] (Out until Nov 14)]

Ryan, I'm picking up bugs. Feel free to assign this one to me.

Comment 3

[Bobby Holley (:bholley)]

Ryan was going to look at this today and make this more actionable.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, I've filed specific bugs and have a patch to update annotations for devtools/client/inspector/rules.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3df7528bec9ebd6968c2c6f3c9fe7cad303a884

I also want to check on RDM, so I'll look at that tomorrow.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Accidentally cancelled the try run, here's another:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b1cfe2c67e072e16cd0d1ee2689798c3472cdc1

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, looks like the rules annotation updates are okay:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed5e4082a420a5f8cb3238145285326066e92abe

and also the RDM updates:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78e4421a28af4aa94d11d3fba95ede9ac1fc9d0f

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1387445 - Update Stylo DevTools annotations.

Review commit: https://reviewboard.mozilla.org/r/174406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174406/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1387445 - Enable DevTools RDM tests on Linux debug.

Review commit: https://reviewboard.mozilla.org/r/174408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174408/

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8902752 [details]
Bug 1387445 - Update Stylo DevTools annotations.

https://reviewboard.mozilla.org/r/174406/#review179752

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8902753 [details]
Bug 1387445 - Enable DevTools RDM tests on Linux debug.

https://reviewboard.mozilla.org/r/174408/#review179754

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/349be74f60cd
Update Stylo DevTools annotations. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/80c7e2729fc9
Enable DevTools RDM tests on Linux debug. r=xidorn

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/349be74f60cd
https://hg.mozilla.org/mozilla-central/rev/80c7e2729fc9