1387455 - Crash in mozilla::layers::PaintItemByDrawTarget

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-29436b83-e094-4601-b7b3-e735b0170723.
=============================================================

Seen while looking at nightly - these go back to at least 20170722072631 when nightly was in 56: http://bit.ly/2wrWW4s

Comment 1

[Kartikaya Gupta (email:[e-mail])]

null drawtarget in the fallback path, looks like?

Comment 2

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #1)
> null drawtarget in the fallback path, looks like?

Right, WebRenderPaintedLayer has the nullptr check[1]. I should add it.

[1] https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/gfx/layers/wr/WebRenderPaintedLayer.cpp#64

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Bug 1387455 - Add nullptr check for the draw target in WebRenderLayerManager::GenerateFallbackData.

Review commit: https://reviewboard.mozilla.org/r/165560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165560/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8894381 [details]
Bug 1387455 - Add nullptr check for the draw target in WebRenderLayerManager::GenerateFallbackData.

https://reviewboard.mozilla.org/r/165560/#review170772

::: commit-message-fe660:1
(Diff revision 1)
> +Bug 1387455 - Add nullptr check for the draw taget in WebRenderLayerManager::GenerateFallbackData. r=kats

s/taget/target/

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8894381 [details]
Bug 1387455 - Add nullptr check for the draw target in WebRenderLayerManager::GenerateFallbackData.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165560/diff/1-2/

Comment 6

[Ethan Lin[:ethlin]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb62581c5f12cc2a499d9ac3c15d842c0a606350

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1674bc5b317
Add nullptr check for the draw target in WebRenderLayerManager::GenerateFallbackData. r=kats

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1674bc5b317