1387528 - implement non-interval markers for console.timeStamp console.time, and console.timeEnd

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P1)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

In this issue https://github.com/devtools-html/perf.html/issues/116 we intend to expose markers for console.timeStamp, console.time, and console.timeEnd.  To achieve this we need to implement a set of non-interval markers for those console methods.

Note: you can see when console.timeStamp was implemented in bug 922221 there were a set of DocShell markers implemented for the console methods.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1387528 - Add profiler markers for console.time{,End} pair and console.timeStamp r?mstange,dcarver

Before we switched to the Firefox Profiler in the DevTools, we had
timeline markers for these console methods. But apparently, since we did
the switch, we never added markers for them.

From our conversations with Chrome folks, they mentioned that some JS
frameworks started using these instead of performance.mark/measure
combinations especially the console.timeStamp one since it's just an
instant marker, stating that they are higher overhead. Even though I
don't completely understand their rationale, I think it makes sense to
add markers for these methods. It essentially adds 2 different subtypes
that uses the same ConsoleTimingMarker.

1. console.time and console.timeEnd when combined create a duration
   marker with a label, similar to performance.mark and measure.
2. console.timeStamp creates an instant marker with a label.

One edge case is that, console.timeEnd doesn't create any markers when
it doesn't have a console.time with the same title, and vice versa.

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1387528 - Add some profiler tests for the console.time/timeEnd/timeStamp methods r?mstange,dcarver

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/19212ac33b7b
https://hg.mozilla.org/integration/autoland/rev/6136cfaf8806
Add profiler markers for console.time{,End} pair and console.timeStamp r=dcarver
https://github.com/mozilla-firefox/firefox/commit/7d26a8874042
https://hg.mozilla.org/integration/autoland/rev/5ccee7389e73
Add some profiler tests for the console.time/timeEnd/timeStamp methods r=dcarver,profiler-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6136cfaf8806
https://hg.mozilla.org/mozilla-central/rev/5ccee7389e73