Closed Bug 1387569 Opened 7 years ago Closed 7 years ago

Also enable -Wno-implicit-fallthrough for gcc (exists from gcc 7)

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(5 files)

Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in dom/canvas (exists from gcc 7)
59 bytes, text/x-review-board-request
jgilbert
: review+
Details
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in jsoncpp (exists from gcc 7)
59 bytes, text/x-review-board-request
kip
: review+
Details
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7)
59 bytes, text/x-review-board-request
ted
: review+
Details
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7)
59 bytes, text/x-review-board-request
gcp
: review+
Details
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for parser/html (exists from gcc 7)
59 bytes, text/x-review-board-request
hsivonen
: review+
Details 
      No description provided.
Blocks: MOZ_FALLTHROUGH
Attachment #8893971 - Flags: review?(wmccloskey) → review?(hsivonen)
Comment on attachment 8893967 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in dom/canvas (exists from gcc 7)

https://reviewboard.mozilla.org/r/165028/#review170466
Attachment #8893967 - Flags: review?(jgilbert) → review+
Comment on attachment 8893970 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7)

https://reviewboard.mozilla.org/r/165034/#review170542

::: security/sandbox/linux/moz.build:95
(Diff revision 1)
>      CXXFLAGS += ['-Wno-shadow']
>      SOURCES['../chromium/sandbox/linux/services/syscall_wrappers.cc'].flags += [
>          '-Wno-empty-body',
>      ]
>  
> +    SOURCES['../chromium/base/third_party/icu/icu_utf.cc'].flags += [

Note that the exact same is done for CLANG_CXX a few lines up, please merge both branches.
Attachment #8893970 - Flags: review?(gpascutto)
Comment on attachment 8893971 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for parser/html (exists from gcc 7)

https://reviewboard.mozilla.org/r/165036/#review170566

::: parser/html/moz.build:103
(Diff revision 1)
>      '/dom/base',
>  ]
>  
>  if CONFIG['GNU_CXX']:
>      CXXFLAGS += ['-Wno-error=shadow']
> -    if CONFIG['CLANG_CXX']:
> +    if CONFIG['CLANG_CXX'] or CONFIG['GNU_CXX']:

There's already an `if CONFIG['GNU_CXX']:` two lines up, so shouldn't this `if` be removed instead of extending its condition?
Comment on attachment 8893970 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7)

https://reviewboard.mozilla.org/r/165034/#review170694
Attachment #8893970 - Flags: review?(gpascutto) → review+
Comment on attachment 8893968 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in jsoncpp (exists from gcc 7)

https://reviewboard.mozilla.org/r/165030/#review171402

LGTM, Thanks!
Attachment #8893968 - Flags: review?(kgilbert) → review+
Comment on attachment 8893971 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for parser/html (exists from gcc 7)

https://reviewboard.mozilla.org/r/165036/#review172220
Attachment #8893971 - Flags: review?(hsivonen) → review+
In case you missed the comment, thanks!
Flags: needinfo?(ted)
Comment on attachment 8893969 [details]
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7)

https://reviewboard.mozilla.org/r/165032/#review175492

::: toolkit/crashreporter/crashreporter.mozbuild:32
(Diff revision 1)
>          '-Wno-deprecated-declarations',
>          '-Wno-bool-compare',
>          '-Wno-unused-but-set-variable',
>      ]
>  
> -if CONFIG['CLANG_CXX'] or CONFIG['CLANG_CL']:
> +if CONFIG['CLANG_CXX'] or CONFIG['CLANG_CL'] or CONFIG['GNU_CXX']:

Does this just want to become `if not CONFIG['MSVC']`?

Also: this won't produce an extraneous warning about this being an unknown warning flag in GCC < 7, will it?
Attachment #8893969 - Flags: review?(ted) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f210c7c8d115
Also enable -Wno-implicit-fallthrough for gcc in dom/canvas (exists from gcc 7) r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/9f03844eb810
Also enable -Wno-implicit-fallthrough for gcc in jsoncpp (exists from gcc 7) r=kip
https://hg.mozilla.org/integration/autoland/rev/9e1a17f94c93
Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7) r=ted
https://hg.mozilla.org/integration/autoland/rev/10660affe7a3
Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7) r=gcp
https://hg.mozilla.org/integration/autoland/rev/8f191f6eec22
Also enable -Wno-implicit-fallthrough for gcc for parser/html (exists from gcc 7) r=hsivonen
Backed out for build bustage in crashreporter on Windows:

https://hg.mozilla.org/integration/autoland/rev/d6ad62cf94b3f1e095e21a85e5daa92be1f1f998
https://hg.mozilla.org/integration/autoland/rev/3c2d100f96441fcc754128bfd9ffd42e67554e93
https://hg.mozilla.org/integration/autoland/rev/b2c0edddf23b6bab3f0f487158005643db75d248
https://hg.mozilla.org/integration/autoland/rev/540d4638b8b074a24f411215b5fbb962692f09ec
https://hg.mozilla.org/integration/autoland/rev/c0bbfddcfef1a5d31fee82872dc3f06396af1841

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8f191f6eec22fcf961300a79b0ecd7de7c4811ad&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=124331813&repo=autoland

17:56:24     INFO -  cl : Command line error D8021 : invalid numeric argument '/Wno-implicit-fallthrough'
17:56:24     INFO -  z:/build/build/src/config/rules.mk:1064: recipe for target 'Unified_cpp_crashreporter0.obj' failed
17:56:24     INFO -  mozmake.EXE[5]: *** [Unified_cpp_crashreporter0.obj] Error 2
17:56:24     INFO -  mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/toolkit/crashreporter'
17:56:24     INFO -  z:/build/build/src/config/recurse.mk:73: recipe for target 'toolkit/crashreporter/target' failed
17:56:24     INFO -  mozmake.EXE[4]: *** [toolkit/crashreporter/target] Error 2
17:56:24     INFO -  mozmake.EXE[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(sledru)
I relied on
`if not CONFIG['MSVC']`?
should have been
_MVC_VER
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20151eabffea
Also enable -Wno-implicit-fallthrough for gcc in dom/canvas (exists from gcc 7) r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/f642bc883aa5
Also enable -Wno-implicit-fallthrough for gcc in jsoncpp (exists from gcc 7) r=kip
https://hg.mozilla.org/integration/autoland/rev/b5f969313f81
Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7) r=ted
https://hg.mozilla.org/integration/autoland/rev/8d23caf2ccc7
Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7) r=gcp
https://hg.mozilla.org/integration/autoland/rev/eeda521ba0ad
Also enable -Wno-implicit-fallthrough for gcc for parser/html (exists from gcc 7) r=hsivonen
Flags: needinfo?(ted)
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/140a1eed2478
Also enable -Wno-implicit-fallthrough for gcc in dom/canvas (exists from gcc 7) r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/1085e5ab8874
Also enable -Wno-implicit-fallthrough for gcc in jsoncpp (exists from gcc 7) r=kip
https://hg.mozilla.org/integration/autoland/rev/9e6e6e912108
Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7) r=ted
https://hg.mozilla.org/integration/autoland/rev/129dc3e3bb4d
Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7) r=gcp
https://hg.mozilla.org/integration/autoland/rev/29011745079b
Also enable -Wno-implicit-fallthrough for gcc for parser/html (exists from gcc 7) r=hsivonen
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: