Closed
Bug 1387700
Opened 7 years ago
Closed 7 years ago
remove scrollByPage
Categories
(Toolkit :: UI Widgets, task, P5)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1387084 +++ > > ::: toolkit/content/widgets/scrollbox.xml:272 > > (Diff revision 3) > > > <method name="scrollByPage"> > > > <parameter name="pageDelta"/> > > > - <parameter name="aSmoothScroll"/> > > > + <parameter name="aInstant"/> > > > > I couldn't find any callers for this. Am I missing something, or should we > > remove this? > > It looks like _distanceScroll should maybe call this. I can't say off-hand > if there are differences and whether they would be intentional.
|
||
Updated•7 years ago
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: use or remove scrollByPage → remove scrollByPage
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Blocks: war-on-xbl
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928535 [details] Bug 1387700 - Remove unused scrollByPage method. https://reviewboard.mozilla.org/r/199788/#review204882
Attachment #8928535 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40afac82ba81 Remove unused scrollByPage method. r=Gijs
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/40afac82ba81
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•6 years ago
|
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•