Closed
Bug 1387720
Opened 7 years ago
Closed 7 years ago
Remove deprecated openTopWin function
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: dao, Assigned: ikram, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
|
686 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•7 years ago
|
||
I am submitting a Patch, hence assigning myself :)
Assignee: nobody → hossainalikram
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
I removed the function. Let me know, If there is any modification, I should do :)
Attachment #8894098 -
Flags: review?(dao+bmo)
|
Reporter | |
Comment 3•7 years ago
|
||
Comment on attachment 8894098 [details] [diff] [review]
Removed-Function.patch
Looks good, thanks!
Attachment #8894098 -
Flags: review?(dao+bmo) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Should it be gone for checkin needed?
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d89045115528
Remove deprecated getTopWin function. r=dao
Keywords: checkin-needed
|
|
Reporter | |
Updated•7 years ago
|
Summary: Remove deprecated getTopWin function → Remove deprecated openTopWin function
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•