1387750 - Light theme on Windows 7 glass impossible to use

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Mark Straver]

Attachment: Image1.png

Just updated to 57 nightly.
The light theme (because "default" is just ugly white...) on Windows 7 with glass has black on black tab text, making it impossible to use.
See screenshot.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1387750 - Make Windows 7 tabs use chrome background when inactive.

Review commit: https://reviewboard.mozilla.org/r/166692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166692/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8895491 [details]
Bug 1387750 - Make Windows 7 tabs use chrome background when inactive.

https://reviewboard.mozilla.org/r/166692/#review171864

::: browser/themes/windows/compacttheme.css:37
(Diff revision 1)
>  
>  #toolbar-menubar {
>    text-shadow: none !important;
>  }
>  
> +@media (-moz-os-version: windows-win7) {

As I understand it, this should be:

@media (-moz-windows-glass) {

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8895491 [details]
Bug 1387750 - Make Windows 7 tabs use chrome background when inactive.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166692/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/408174c3122a
Make Windows 7 tabs use chrome background when inactive. r=dao

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/408174c3122a

Comment 6

[Deac Alin]

Verified the issue on Windows 7 x 64 bit on latest Nightly 57.0a1 ID 20170815100349. The issue is not reproducible. Light theme with windows glass is now properly displayed. I will mark this as verified fixed. Thank you

Comment 7

[Mark Straver]

I just tried nightly 2017-8-16 on Win 7 x64. The issue is NOT completely solved. Although the tab backgrounds are OK, the tab controls (new tab "+", scroll arrows, drop-down chevron) can still be completely invisible because the background is still non-fogged glass. At the very least it is extremely low contrast, at its worst it completely blends away.

Comment 8

[Mark Straver]

Attachment: Invisible "New Tab" control

Example of the new tab control completely blending out into the background.

Comment 9

[Mark Straver]

Attachment: dark-controls2.png

The left window corner is fogged so it provides some contrast with the control. The right corner isn't, which is still a problem. If you want to use these kinds of controls on glass, maybe you need to outline them?

Comment 10

[Johann Hofmann [:johannh]]

Please file new bugs.

Comment 11

[Mark Straver]

*eyeroll* OK, fine.

Filed bug 1391227 reiterating what still makes the theme unusable.