Closed Bug 1387755 Opened 7 years ago Closed 7 years ago

tab separator color is too light

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.2 - Aug 29
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: asa, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual][p4])

Attachments

(1 file)

According to http://design.firefox.com/people/shorlander/photon/Mockups/windows-10.html the current tab separator color is too light. The current color seems to be HSL 156,18,121 or RGB 119,121,138 and it should be HSL 157,30,93 or RGB 86,88,111
Whiteboard: [photon-visual][triage]
Blocks: photon-tabs
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p3]
Flags: qe-verify?
Priority: -- → P3
Flags: qe-verify? → qe-verify+
Whiteboard: [reserve-photon-visual][p3] → [reserve-photon-visual][p4]
QA Contact: brindusa.tot
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: P3 → P1
Iteration: --- → 57.1 - Aug 15
Iteration: 57.1 - Aug 15 → 57.2 - Aug 29
Comment on attachment 8897372 [details]
Bug 1387755 - Use 20% opaque tab separators regardless of the tab toolbar background.

https://reviewboard.mozilla.org/r/168690/#review174408

Looks good cheers
Attachment #8897372 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46e855a326b8
Use 20% opaque tab separators regardless of the tab toolbar background. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/46e855a326b8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
QA Contact: brindusa.tot → ovidiu.boca
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170921220243

I can reproduce this issue on Firefox Nightly Build ID: 20170403030207 on Windows 8.1 x64.

This issue has been verified on latest Firefox Nightly Build ID: 20170921220243 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04 and I cannot reproduce it. Now, the tab separator line is darker.
Status: RESOLVED → VERIFIED
After further investigation, although the tab separator is darker the RGB for it is (60, 60, 61) and not RGB 86,88,111 as mentioned in comment 1.

Also, when the tab is selected, the tab separator has RGB(91, 91, 91).

Are these behaviours expected or it is an issue?
Flags: needinfo?(dharvey)
Flags: needinfo?(dao+bmo)
(In reply to Vlad Bacia-Mociran [:VladB] from comment #6)
> After further investigation, although the tab separator is darker the RGB
> for it is (60, 60, 61) and not RGB 86,88,111 as mentioned in comment 1.
> 
> Also, when the tab is selected, the tab separator has RGB(91, 91, 91).
> 
> Are these behaviours expected or it is an issue?

That's fine for now. The separator color depends on the text color which is lighter in the mockup than the OS-native text color we're using.
Flags: needinfo?(dharvey)
Flags: needinfo?(dao+bmo)
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170928180207

This issue has been verified on latest Firefox Beta 57.0b4 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04 and it is the same as in Nightly.

Thus, based on comment 7 this issue is fixed.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: