1387789 - Convert ExtensionTabs.jsm to an API script

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Kris Maglione [:kmag]]

Having ExtensionTabs.jsm in a separate compartment prevents effective JIT optimization, and makes things like Tab.convert an order of magnitude slower. After moving it to an ordinary API script, that function disappears from profiles entirely.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1387789: Convert ExtensionTabs.jsm to ext-tabs-base.js.

This moves it to the same compartment as the code that it interfaces with the
most often, and allows for much more effective JIT optimizations.

Review commit: https://reviewboard.mozilla.org/r/165206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165206/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8894141 [details]
Bug 1387789: Convert ExtensionTabs.jsm to ext-tabs-base.js.

https://reviewboard.mozilla.org/r/165206/#review170830

nice

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/814688712ca461dd650e9a4cf80df274effc4a8c
Bug 1387789: Convert ExtensionTabs.jsm to ext-tabs-base.js. r=mixedpuppy

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/814688712ca4

Comment 5

[Madalin Cotetiu]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!