Closed Bug 1387789 Opened 2 years ago Closed 2 years ago

Convert ExtensionTabs.jsm to an API script

Categories

(WebExtensions :: General, enhancement)

enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Having ExtensionTabs.jsm in a separate compartment prevents effective JIT optimization, and makes things like Tab.convert an order of magnitude slower. After moving it to an ordinary API script, that function disappears from profiles entirely.
Comment on attachment 8894141 [details]
Bug 1387789: Convert ExtensionTabs.jsm to ext-tabs-base.js.

https://reviewboard.mozilla.org/r/165206/#review170830

nice
Attachment #8894141 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/mozilla-central/rev/814688712ca4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1373418
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.