Closed Bug 1387948 Opened 7 years ago Closed 7 years ago

stylo: Interpolation of font-weight is not correct in test_transitions_per_property.html

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- fixed

People

(Reporter: boris, Assigned: boris)

References

Details

Attachments

(2 files, 1 obsolete file)

Got these three failures:

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | font-weight property font-weight: interpolation of font-weights - got "900", expected "500"

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | font-weight property font-weight: interpolation of font-weights - got "900", expected "700"

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | font-weight property font-weight: clamping of values - got "900", expected "100"
Assignee: nobody → boris.chiou
This may be a regression. I didn't see this failure before. Now the interpolation of FontWeight is broken.
This is a regression of this: https://github.com/servo/servo/pull/17430
Comment on attachment 8894762 [details]
Bug 1387948 - Fix the computation of the interpolation of FontWeight.

https://reviewboard.mozilla.org/r/165930/#review171044
Attachment #8894762 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8894763 [details]
Bug 1387948 - Enable font-weight in test_transitions_per_property.html for stylo.

https://reviewboard.mozilla.org/r/165932/#review171046

These two commits can be squashed into one, actually.
Attachment #8894763 - Flags: review?(xidorn+moz) → review+
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #6)
> These two commits can be squashed into one, actually.

Yes, but one is in Servo, another one is in Gecko. :(
Attachment #8894762 - Attachment is obsolete: true
Attached file Servo PR, #18007
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d99d21fbb19
Enable font-weight in test_transitions_per_property.html for stylo. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/1d99d21fbb19
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: