1387948 - stylo: Interpolation of font-weight is not correct in test_transitions_per_property.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Chiou [:boris]]

Got these three failures:

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | font-weight property font-weight: interpolation of font-weights - got "900", expected "500"

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | font-weight property font-weight: interpolation of font-weights - got "900", expected "700"

TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | font-weight property font-weight: clamping of values - got "900", expected "100"

Comment 1

[Boris Chiou [:boris]]

This may be a regression. I didn't see this failure before. Now the interpolation of FontWeight is broken.

Comment 2

[Boris Chiou [:boris]]

This is a regression of this: https://github.com/servo/servo/pull/17430

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1387948 - Fix the computation of the interpolation of FontWeight.

Review commit: https://reviewboard.mozilla.org/r/165930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165930/

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1387948 - Enable font-weight in test_transitions_per_property.html for stylo.

Review commit: https://reviewboard.mozilla.org/r/165932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165932/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8894762 [details]
Bug 1387948 - Fix the computation of the interpolation of FontWeight.

https://reviewboard.mozilla.org/r/165930/#review171044

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8894763 [details]
Bug 1387948 - Enable font-weight in test_transitions_per_property.html for stylo.

https://reviewboard.mozilla.org/r/165932/#review171046

These two commits can be squashed into one, actually.

Comment 7

[Boris Chiou [:boris]]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #6)
> These two commits can be squashed into one, actually.

Yes, but one is in Servo, another one is in Gecko. :(

Comment 8

[Boris Chiou [:boris]]

Attachment: Servo PR, #18007

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d99d21fbb19
Enable font-weight in test_transitions_per_property.html for stylo. r=xidorn

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d99d21fbb19