If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove BrowserCustomizeToolbar

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: dao, Assigned: ikram, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

Trunk
Firefox 57
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago
We need to replace BrowserCustomizeToolbar() with gCustomizeMode.enter() here:

http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/browser/base/content/browser-sets.inc#37

http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/browser/base/content/browser.xul#367

and remove this:

http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/browser/base/content/browser.js#4245-4248
(Assignee)

Comment 1

2 months ago
I am interested in working on it, hence assigning myself :)
Assignee: nobody → hossainalikram
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 months ago
Created attachment 8894583 [details] [diff] [review]
Removed-renamed-functions.patch

Let me know, If any modification is needed :)
Attachment #8894583 - Flags: review?(dao+bmo)
(Reporter)

Comment 3

a month ago
Comment on attachment 8894583 [details] [diff] [review]
Removed-renamed-functions.patch

Looks good, thanks!
Attachment #8894583 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

a month ago
Keywords: checkin-needed

Comment 4

a month ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5370f4a84268
Remove BrowserCustomizeToolbar. r=dao
Keywords: checkin-needed

Comment 5

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5370f4a84268
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.