Closed
Bug 1388032
Opened 7 years ago
Closed 7 years ago
Remove BrowserCustomizeToolbar
Categories
(Firefox :: Toolbars and Customization, enhancement)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: dao, Assigned: ikram, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
1.96 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
We need to replace BrowserCustomizeToolbar() with gCustomizeMode.enter() here: http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/browser/base/content/browser-sets.inc#37 http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/browser/base/content/browser.xul#367 and remove this: http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/browser/base/content/browser.js#4245-4248
|
Assignee | |
Comment 1•7 years ago
|
||
I am interested in working on it, hence assigning myself :)
Assignee: nobody → hossainalikram
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
Let me know, If any modification is needed :)
Attachment #8894583 -
Flags: review?(dao+bmo)
|
Reporter | |
Comment 3•7 years ago
|
||
Comment on attachment 8894583 [details] [diff] [review] Removed-renamed-functions.patch Looks good, thanks!
Attachment #8894583 -
Flags: review?(dao+bmo) → review+
|
|
Reporter | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5370f4a84268 Remove BrowserCustomizeToolbar. r=dao
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5370f4a84268
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•