Intersection of current tab side border and other tabs bottom border gets double opacity

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
11 months ago
6 months ago

People

(Reporter: SimonSapin, Assigned: dao)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [reserve-photon-visual][p3])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

11 months ago
In 57.0a1 (2017-08-07), at least on Linux, the current tab gets a solid grey border on the left and right. Other tabs get the same solid grey border on the bottom. The two 1x1 px corners where these borders intersect are a darker grey. It would be nicer if these corners kept the same colors.

I’m guessing that this is two semi-transparent borders that overlap. The darker grey comes from alpha-blending them together.

Indeed, looking around devtools I find .tab-background[selected="true"] { border-color: var(--tabs-border) } which computes to rgba(0, 0, 0, 0.3).
(Reporter)

Comment 1

11 months ago
Created attachment 8894499 [details]
tab 500%.png

Magnified screenshot

Updated

11 months ago
Whiteboard: [photon-visual][triage]
(Assignee)

Updated

11 months ago
Blocks: 1355767
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p3]

Updated

11 months ago
Flags: qe-verify?
Priority: -- → P3
(Assignee)

Updated

11 months ago
Flags: qe-verify? → qe-verify+

Updated

11 months ago
QA Contact: brindusa.tot
(Assignee)

Updated

10 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
OS: Linux → All
Priority: P3 → P1
Hardware: Unspecified → All
Comment hidden (mozreview-request)

Updated

10 months ago
Iteration: --- → 57.1 - Aug 15

Comment 3

10 months ago
mozreview-review
Comment on attachment 8896620 [details]
Bug 1388044 - Make the tab side borders not overlap the border to the navigation toolbar.

https://reviewboard.mozilla.org/r/167908/#review173428

Very clever! I hope talos likes it as much as I do :)
Attachment #8896620 - Flags: review?(jhofmann) → review+

Comment 4

10 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a1b0b22bfcd
Make the tab side borders not overlap the border to the navigation toolbar. r=johannh

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2a1b0b22bfcd
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=824d4f269c6323e1ad2bd8ebeb6496d60b8ba3e5&newProject=mozilla-central&newRev=92f3de33d97f55d54b2baad585b87e76aaa5ec58

I know there's a lot going on in this push, but e.g. in the first Linux screenshots you can actually see something changed in the corner of the tabs.
Depends on: 1390472
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
QA Contact: brindusa.tot → Virtual

Updated

10 months ago
Flags: qe-verify+
(Assignee)

Updated

6 months ago
Blocks: 1424992
You need to log in before you can comment on or make changes to this bug.