1388044 - Intersection of current tab side border and other tabs bottom border gets double opacity

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Simon Sapin (:SimonSapin)]

In 57.0a1 (2017-08-07), at least on Linux, the current tab gets a solid grey border on the left and right. Other tabs get the same solid grey border on the bottom. The two 1x1 px corners where these borders intersect are a darker grey. It would be nicer if these corners kept the same colors.

I’m guessing that this is two semi-transparent borders that overlap. The darker grey comes from alpha-blending them together.

Indeed, looking around devtools I find .tab-background[selected="true"] { border-color: var(--tabs-border) } which computes to rgba(0, 0, 0, 0.3).

Comment 1

[Simon Sapin (:SimonSapin)]

Attachment: tab 500%.png

Magnified screenshot

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1388044 - Make the tab side borders not overlap the border to the navigation toolbar.

Review commit: https://reviewboard.mozilla.org/r/167908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167908/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8896620 [details]
Bug 1388044 - Make the tab side borders not overlap the border to the navigation toolbar.

https://reviewboard.mozilla.org/r/167908/#review173428

Very clever! I hope talos likes it as much as I do :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a1b0b22bfcd
Make the tab side borders not overlap the border to the navigation toolbar. r=johannh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a1b0b22bfcd

Comment 6

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=824d4f269c6323e1ad2bd8ebeb6496d60b8ba3e5&newProject=mozilla-central&newRev=92f3de33d97f55d54b2baad585b87e76aaa5ec58

I know there's a lot going on in this push, but e.g. in the first Linux screenshots you can actually see something changed in the corner of the tabs.

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.