1388088 - HSTS periodic update failing with: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIXPCComponents_Utils.import]

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

The HSTS periodic update process broke starting on 2017-07-26:
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-linux64/mozilla-central-linux64-periodicupdate-bm74-build1-build2.txt.gz
> INFO: Generating new HSTS preload list...
> INFO: Running "LD_LIBRARY_PATH=/builds/slave/m-cen-l64-periodicupdate-00000/gtk3/usr/local/lib:/builds/slave/m-cen-l64-periodicupdate-00000/gcc/lib64:/builds/slave/m-cen-l64-periodicupdate-00000/gcc/lib:. ./xpcshell /builds/slave/m-cen-l64-periodicupdate-00000/getHSTSPreloadList.js /builds/slave/m-cen-l64-periodicupdate-00000/nsSTSPreloadList.inc"
> JavaScript error: /builds/slave/m-cen-l64-periodicupdate-00000/getHSTSPreloadList.js, line 22: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIXPCComponents_Utils.import]

The line it's complaining about is this:
https://hg.mozilla.org/mozilla-central/file/f904bc721e7d/security/manager/tools/getHSTSPreloadList.js#l22
> Cu.import("resource:///modules/XPCOMUtils.jsm");

Comment 1

[:Cykesiopka]

Attachment: Bug 1388088 - Fix incorrect Cu.import() URL to unbreak HSTS periodic updates.

The preload script currently imports XPCOMUtils.jsm like so:
> Cu.import("resource:///modules/XPCOMUtils.jsm");

As explained in Bug 1383215 comments [21, 24], this has been incorrect for
years, but happened to work.

The import URL is changed so it points at the correct thing now:
> Cu.import("resource://gre/modules/XPCOMUtils.jsm");

Review commit: https://reviewboard.mozilla.org/r/165710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165710/

Comment 2

[Kris Maglione [:kmag]]

(In reply to :Cykesiopka from comment #0)
> The line it's complaining about is this:
> https://hg.mozilla.org/mozilla-central/file/f904bc721e7d/security/manager/
> tools/getHSTSPreloadList.js#l22
> > Cu.import("resource:///modules/XPCOMUtils.jsm");

That needs to be changed to resource://gre/modules/XPCOMUtils.jsm. I'm surprised it works at all as-is.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8894553 [details]
Bug 1388088 - Fix incorrect Cu.import() URL to unbreak HSTS periodic updates.

https://reviewboard.mozilla.org/r/165710/#review170824

Yay cargo-culting.
Thanks for fixing this.

::: security/manager/tools/getHSTSPreloadList.js:22
(Diff revision 1)
>  var Cu = Components.utils;
>  var Cr = Components.results;
>  
>  Cu.import("resource://gre/modules/Services.jsm");
>  Cu.import("resource://gre/modules/FileUtils.jsm");
> -Cu.import("resource:///modules/XPCOMUtils.jsm");
> +Cu.import("resource://gre/modules/XPCOMUtils.jsm");

¯\_(ツ)_/¯

Comment 4

[:Cykesiopka]

Thanks for the review.
(This change is NPOTB.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/946c7dc6aaa4
Fix incorrect Cu.import() URL to unbreak HSTS periodic updates. r=keeler

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/946c7dc6aaa4