1388098 - Fix disable/enable hides extension options on Firefox for Android

Status: VERIFIED FIXED

(WebExtensions :: Android, defect, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This is a follow up of Bug 1385880, which fixes the same issue on Firefox Desktop.

Now that Bug 1385880 has been landed on mozilla-central and it has introduced the `startupPromise` property on the `addon` wrapper object, we can use this promise to ensure that the webextension options ui iframe is shown as expected when the addon is disabled and immediately enabled from the "about:addons" page on Firefox for Android.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1388098 - Fix Android options_ui on disable/enable addon.

Review commit: https://reviewboard.mozilla.org/r/165718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165718/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8894560 [details]
Bug 1388098 - Fix Android options_ui on disable/enable addon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165718/diff/1-2/

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8894560 [details]
Bug 1388098 - Fix Android options_ui on disable/enable addon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165718/diff/2-3/

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8894560 [details]
Bug 1388098 - Fix Android options_ui on disable/enable addon.

https://reviewboard.mozilla.org/r/165718/#review175554

::: mobile/android/components/extensions/test/mochitest/test_ext_options_ui.html:447
(Diff revision 3)
> +  info("Wait the addon details to have been loaded");
> +  await ContentTask.spawn(aboutAddonsTab.browser, addonID, waitAboutAddonsRendered);
> +  await ContentTask.spawn(aboutAddonsTab.browser, addonID, navigateToAddonDetails);
> +
> +  info("Wait the addon options page to have been loaded");
> +  await extension.awaitMessage("options-page-loaded");

is there a potential race here with the above tasks?

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8894560 [details]
Bug 1388098 - Fix Android options_ui on disable/enable addon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165718/diff/3-4/

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8894560 [details]
Bug 1388098 - Fix Android options_ui on disable/enable addon.

https://reviewboard.mozilla.org/r/165718/#review175554

> is there a potential race here with the above tasks?

The `browser.test` messages are collected by the extension test utils and so `extension.awaitMessage` should be resolve to handle it correctly (by resolving immediatelly if the message has been already received and collected or by waiting until the options page is able to load and send the test message, also if any `browser.test` message is still in the queue while the test is exiting, it is automatically detected and raised as an error).

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8894560 [details]
Bug 1388098 - Fix Android options_ui on disable/enable addon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165718/diff/4-5/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd645c43199c
Fix Android options_ui on disable/enable addon. r=mixedpuppy

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cd645c43199c

Comment 10

[CosminB]

Attachment: Bug1388098.gif

This issue is verified as fixed on Fennec 57.0a1 (2017-09-07) under Android 6.0.1.

Options_ui is shown as expected when the extension is disabled and immediately enabled from the "about:addons" web page.

Please see the attached video.