1388100 - Errors in the preprocessor related to else-mismatches should include which file they are in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
In /toolkit/content/xul.css, insert an errant #else
Build Firefox

Actual results:
In the build output, should see a message that says:
WARNING: bad nesting of #else

Expected results:
In the build output, should see a message that says:
WARNING: bad nesting of #else in c:\fx\toolkit\content\xul.css

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

In comment #0, I meant to say "insert an errant %else" because this is a CSS file.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1388100 - Log filenames of else mismatches in the preprocessor.

Review commit: https://reviewboard.mozilla.org/r/165722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165722/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I ran in to this while working on bug 1385913. Having the filename listed would have made this easier to narrow down. I ended up adding this logging to find my mistake.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8894562 [details]
Bug 1388100 - Log filenames of else mismatches in the preprocessor.

https://reviewboard.mozilla.org/r/165722/#review170854

::: python/mozbuild/mozbuild/preprocessor.py:581
(Diff revision 1)
>          if args in self.context:
>              del self.context[args]
>      # Logic
>      def ensure_not_else(self):
>          if len(self.ifStates) == 0 or self.ifStates[-1] == 2:
> -            sys.stderr.write('WARNING: bad nesting of #else\n')
> +            sys.stderr.write('WARNING: bad nesting of #else in %s\n' % self.context['FILE'])

I'd be tempted to make this a fatal error by raising `Preprocessor.Error`. However, my guess is it is a rabbit hole. Improving the message is an obvious step forward. So r+.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ab346b62f90
Log filenames of else mismatches in the preprocessor. r=gps

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ab346b62f90