Closed
Bug 1388104
Opened 7 years ago
Closed 7 years ago
No context menu in console input
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox56 wontfix, firefox57 verified)
People
(Reporter: Oriol, Assigned: bgrins)
References
Details
(Whiteboard: [reserve-console-html])
Attachments
(2 files)
1. Open the web console 2. Right-click the input box Expected: context menu Result: nothing Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9c8c36344fee1097adf411124ec637ecc2942be8&tochange=d941b592133f9e0aabe24a4f35078445e7aeace0
Assignee | ||
Comment 1•7 years ago
|
||
I believe this is an issue with HTML inputs or HTML documents in the browser chrome in general. For instance, this also affects the debugger and netmonitor. Although the inspector's search textbox does show the menu, so I think there's a workaround with toolbox.openTextBoxContextMenu: * https://dxr.mozilla.org/mozilla-central/source/devtools/client/inspector/inspector.js#1073 * https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/toolbox.js#2555
Assignee | ||
Comment 2•7 years ago
|
||
Mossop, do you know (or know who might know) why the normal edit controls context menu popup doesn't show up on HTML inputs in the browser chrome? I thought I remembered a bug about this but am not able to find it.
Flags: needinfo?(dtownsend)
Updated•7 years ago
|
Whiteboard: [console-html] [triage]
Comment 3•7 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #2) > Mossop, do you know (or know who might know) why the normal edit controls > context menu popup doesn't show up on HTML inputs in the browser chrome? I > thought I remembered a bug about this but am not able to find it. As far as I know it's something that has to be setup manually, the XUL textbox element does this.
Flags: needinfo?(dtownsend)
Updated•7 years ago
|
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [console-html] [triage] → [reserve-console-html]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Updated•7 years ago
|
Iteration: --- → 57.2 - Aug 29
Priority: P3 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8897536 [details] Bug 1388104 - Remove inspector-specific context menu handling for HTML inputs; https://reviewboard.mozilla.org/r/168796/#review174176
Attachment #8897536 -
Flags: review?(gl) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8897535 [details] Bug 1388104 - Open the textbox context menu on any html input in the toolbox; https://reviewboard.mozilla.org/r/168794/#review174206 ::: devtools/client/framework/test/browser_toolbox_textbox_context_menu.js:5 (Diff revision 1) > /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */ > /* vim: set ft=javascript ts=2 et sw=2 tw=80: */ > /* Any copyright is dedicated to the Public Domain. > * http://creativecommons.org/publicdomain/zero/1.0/ */ > Let's add a comment for this test file describing what it tests ::: devtools/client/framework/test/browser_toolbox_textbox_context_menu.js:13 (Diff revision 1) > > -add_task(function* () { > - let toolbox = yield openNewTabAndToolbox(URL, "inspector"); > +registerCleanupFunction(() => { > + gDevTools.unregisterTool(textboxToolId); > +}); > + > +add_task(async function checkMenuEntryStates() { Maybe add an info() here to log what we are testing. ::: devtools/client/framework/test/browser_toolbox_textbox_context_menu.js:52 (Diff revision 1) > is(cmdCopy.getAttribute("disabled"), "", "cmdCopy is enabled"); > is(cmdPaste.getAttribute("disabled"), "", "cmdPaste is enabled"); > +}); > > - yield cleanup(toolbox); > +add_task(async function automaticallyBindTexbox() { > + gDevTools.registerTool({ Add an info() about what this task is testing. ::: devtools/client/framework/test/head.js:206 (Diff revision 1) > */ > function DevToolPanel(iframeWindow, toolbox) { > EventEmitter.decorate(this); > > this._toolbox = toolbox; > + this.window = iframeWindow; s/this.window/this._window to get consistent
Attachment #8897535 -
Flags: review?(gl) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b32d3d44aff Open the textbox context menu on any html input in the toolbox;r=gl https://hg.mozilla.org/integration/autoland/rev/2bc9f7a11013 Remove inspector-specific context menu handling for HTML inputs;r=gl
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9b32d3d44aff https://hg.mozilla.org/mozilla-central/rev/2bc9f7a11013
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 12•7 years ago
|
||
I have reproduced this bug with Nightly 57.0a1 (2017-08-07) (64-bit) on Ubuntu 16.04 LTS! This bug's fix is verified with latest Nightly! Build Id : 20170820100343 User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170816]
Comment 13•7 years ago
|
||
I have reproduced this bug with Nightly 57.0a1 (2017-08-07) on Windows 8.1 ! This bug's fix is verified with latest Nightly! Build Id : 20170820100343 User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170816]
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Flags: qe-verify?
Comment 14•7 years ago
|
||
Too late for 56. Mass won't fix for 56.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•