Telemetry for XMLDocument.async to gauge feasibility of removal

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

No other UA supports this, so it's likely to be basically nothing, but let's check anyway.
Comment hidden (mozreview-request)
Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

Requesting data review.
Attachment #8894838 - Flags: feedback?(francois)

Comment 3

6 months ago
AFAIK IE supports .async. Wasn't that the reason to add it.

Comment 4

6 months ago
mozreview-review
Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

https://reviewboard.mozilla.org/r/165996/#review171302

::: commit-message-52285:3
(Diff revision 1)
> +Bug 1388132 - Enable use counter for XMLDocument.async; r?smaug
> +
> +This API is Gecko-only and we want to ensure there isn't significant

This comment looks wrong. .async is/was IEism.
See for example
https://msdn.microsoft.com/en-us/library/ms761398(v=vs.85).aspx

::: dom/base/UseCounters.conf:82
(Diff revision 1)
>  method DataTransfer.mozSetDataAt
>  method DataTransfer.mozGetDataAt
>  attribute DataTransfer.mozUserCancelled
>  attribute DataTransfer.mozSourceNode
> +
> +// Gecko-only property

Drop the comment
Attachment #8894838 - Flags: review?(bugs) → review+
Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

https://reviewboard.mozilla.org/r/165996/#review171306

datareview+
Attachment #8894838 - Flags: review+
Attachment #8894838 - Flags: feedback?(francois) → feedback+
(Assignee)

Comment 6

6 months ago
mozreview-review-reply
Comment on attachment 8894838 [details]
Bug 1388132 - Enable use counter for XMLDocument.async;

https://reviewboard.mozilla.org/r/165996/#review171302

> This comment looks wrong. .async is/was IEism.
> See for example
> https://msdn.microsoft.com/en-us/library/ms761398(v=vs.85).aspx

https://jsfiddle.net/wu6e266o/ reports "undefined" in Edge, IE11, and IE11 with IE10 compatibility mode, and "true" in Firefox.  (IE9 compatibility mode doesn't load the page properly.)  So we are the only browser that implements it.  The docs page says that it's from MSXML, which Wikipedia says is a legacy set of services for developers of Windows programs, not part of IE.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

6 months ago
Pushed by ayg@aryeh.name:
https://hg.mozilla.org/integration/autoland/rev/d5a7aa8a32ea
Enable use counter for XMLDocument.async; r=francois,smaug

Comment 10

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d5a7aa8a32ea
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.