Closed Bug 1388168 Opened 7 years ago Closed 7 years ago

Fix naming of, and inside, AS highlights and top sites layout files

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1393274

People

(Reporter: mcomella, Unassigned)

References

Details

(Whiteboard: [mobileAS])

There will be merge conflicts if we try to fix this now because multiple people are editing these files but it'd be great to fix the names of the top sites and highlights layout files. For example, for highlights, the file is `activity_stream_card_history_item` and it has views with names like, `page`, which is a TextView featuring the pageDomain. Similarly, we should fix the Top Sites file. While we're at it, TopSitesPage.setTiles should really be TopSitesPage.setTilesCount.
I'll fix the highlights stuff in bug 1393274, top sites seems to have been incidentally fixed, and setTiles doesn't exist anymore.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.